[Web] Add log-level attribute for console verbosity#443
Merged
Conversation
This was referenced Jul 13, 2026
Contributor
Author
This was referenced Jul 13, 2026
markmur
marked this pull request as ready for review
July 13, 2026 18:13
Package Size
Web file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
markmur
force-pushed
the
android-none-log-level
branch
from
July 14, 2026 08:00
1054096 to
b010e3d
Compare
markmur
force-pushed
the
web-log-level-attribute
branch
2 times, most recently
from
July 14, 2026 08:22
acbc2a3 to
e2a9f02
Compare
markmur
force-pushed
the
android-none-log-level
branch
from
July 14, 2026 08:22
b010e3d to
c22b498
Compare
markmur
force-pushed
the
web-log-level-attribute
branch
from
July 14, 2026 08:48
e2a9f02 to
dd25de8
Compare
markmur
force-pushed
the
android-none-log-level
branch
from
July 14, 2026 08:48
c22b498 to
d2ad5fe
Compare
markmur
force-pushed
the
android-none-log-level
branch
from
July 14, 2026 08:59
d2ad5fe to
efee365
Compare
markmur
force-pushed
the
web-log-level-attribute
branch
from
July 14, 2026 08:59
dd25de8 to
80b109a
Compare
markmur
force-pushed
the
android-none-log-level
branch
from
July 14, 2026 10:03
efee365 to
378ab6c
Compare
markmur
force-pushed
the
web-log-level-attribute
branch
2 times, most recently
from
July 14, 2026 10:30
3100346 to
241b93c
Compare
markmur
changed the base branch from
android-none-log-level
to
graphite-base/443
July 14, 2026 11:34
markmur
force-pushed
the
web-log-level-attribute
branch
from
July 14, 2026 11:43
241b93c to
df991a6
Compare
markmur
force-pushed
the
graphite-base/443
branch
from
July 14, 2026 11:43
378ab6c to
497a8db
Compare
markmur
force-pushed
the
web-log-level-attribute
branch
from
July 14, 2026 11:44
df991a6 to
95ddc32
Compare
kieran-osgood-shopify
approved these changes
Jul 14, 2026
kiftio
approved these changes
Jul 14, 2026
Replace the boolean `debug` attribute/property with a `log-level` attribute and `logLevel` property carrying an ordered LogLevel enum (debug, warn, error, none). Levels form a threshold: debug is the most verbose and none silences everything; selecting a level emits that level and every more-severe level. Defaults to warn. Console output is routed through a small Logger utility gated by the current level, replacing the ad-hoc debug-gated warnings.
markmur
force-pushed
the
web-log-level-attribute
branch
from
July 14, 2026 15:54
95ddc32 to
4d6ae40
Compare
westeezy
reviewed
Jul 14, 2026
westeezy
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Replaces the boolean
debugattribute/property with alog-levelattribute andlogLevelproperty carrying an orderedLogLevelenum:debug, warn, error, none.debugis the most verbose,nonesilences everything; selecting a level emits that level and every more-severe level.error. This intentionally diverges from the other platforms (which default towarn): web logs go to the browser console, which is inherently more public than a native device log, so we default to the quietest level that still surfaces failures during integration.Loggerutility gated by the current level, replacing the ad-hocdebug-gated warnings.Threshold
log-leveldebugwarnerror(default)noneUsage
Migration