Skip to content

[Android] Add NONE log level#442

Merged
markmur merged 1 commit into
mainfrom
android-none-log-level
Jul 14, 2026
Merged

[Android] Add NONE log level#442
markmur merged 1 commit into
mainfrom
android-none-log-level

Conversation

@markmur

@markmur markmur commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What

Completes the canonical LogLevel set by adding a NONE case, so errors can be fully silenced.

  • LogLevel is now DEBUG, WARN, ERROR, NONE (ordered, most to least verbose).
  • Gates both LogWrapper.e() overloads on != NONE — previously e() always emitted regardless of level.
  • Default remains WARN.
  • Regenerates the public API baseline.

Threshold

logLevel debug warn error
DEBUG
WARN (default)
ERROR
NONE

Usage

ShopifyCheckoutKit.configure { configuration ->
    configuration.logLevel = LogLevel.DEBUG   // debug + warnings + errors
    configuration.logLevel = LogLevel.WARN    // warnings + errors (default)
    configuration.logLevel = LogLevel.ERROR   // errors only
    configuration.logLevel = LogLevel.NONE    // silence everything
}

markmur commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@markmur
markmur marked this pull request as ready for review July 13, 2026 18:13
@markmur
markmur requested a review from a team as a code owner July 13, 2026 18:13
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.85% (327/356) 87.98% (183/208) 100% (86/86)

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Android release AAR 216.7 KiB 216.8 KiB +34 B
Android file breakdown
File Base Head Delta
classes.jar 229.1 KiB 229.2 KiB +41 B
res/layout/checkout_sheet_content.xml 4.0 KiB 4.0 KiB 0 B
res/values/values.xml 1.2 KiB 1.2 KiB 0 B
R.txt 1.0 KiB 1.0 KiB 0 B
proguard.txt 798 B 798 B 0 B
AndroidManifest.xml 578 B 578 B 0 B
res/drawable/close.xml 431 B 431 B 0 B
res/menu/checkout_menu.xml 354 B 354 B 0 B
META-INF/com/android/build/gradle/aar-metadata.properties 157 B 157 B 0 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

@markmur
markmur requested a review from kiftio July 13, 2026 18:16
@markmur markmur self-assigned this Jul 13, 2026
@markmur
markmur force-pushed the android-none-log-level branch from 1054096 to b010e3d Compare July 14, 2026 08:00
Comment thread platforms/swift/api/ShopifyCheckoutKit.json Outdated
@markmur
markmur force-pushed the swift-canonical-log-levels branch from 20ac9d3 to 5d262ec Compare July 14, 2026 08:22
@markmur
markmur force-pushed the android-none-log-level branch from b010e3d to c22b498 Compare July 14, 2026 08:22
@markmur
markmur force-pushed the swift-canonical-log-levels branch from 5d262ec to 9052ad2 Compare July 14, 2026 08:48
@markmur
markmur force-pushed the android-none-log-level branch from c22b498 to d2ad5fe Compare July 14, 2026 08:48
@markmur
markmur force-pushed the swift-canonical-log-levels branch from 9052ad2 to d825200 Compare July 14, 2026 08:59
@markmur
markmur force-pushed the android-none-log-level branch from d2ad5fe to efee365 Compare July 14, 2026 08:59
@markmur
markmur force-pushed the swift-canonical-log-levels branch from d825200 to abd1ba4 Compare July 14, 2026 10:03
@markmur
markmur force-pushed the android-none-log-level branch from efee365 to 378ab6c Compare July 14, 2026 10:03

markmur commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 14, 11:14 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 14, 11:35 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 14, 11:43 AM UTC: @markmur merged this pull request with Graphite.

@markmur
markmur changed the base branch from swift-canonical-log-levels to graphite-base/442 July 14, 2026 11:15
@markmur
markmur changed the base branch from graphite-base/442 to main July 14, 2026 11:33
Add a NONE case to LogLevel and gate LogWrapper.e() (both overloads)
on it, so errors can be fully silenced. Previously e() always emitted
regardless of log level. Regenerate the public API baseline.
@markmur
markmur force-pushed the android-none-log-level branch from 378ab6c to 0c997ca Compare July 14, 2026 11:34
@markmur
markmur merged commit 497a8db into main Jul 14, 2026
32 checks passed
@markmur
markmur deleted the android-none-log-level branch July 14, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants