[Android] Add NONE log level#442
Merged
Merged
Conversation
This was referenced Jul 13, 2026
Contributor
Author
This was referenced Jul 13, 2026
markmur
marked this pull request as ready for review
July 13, 2026 18:13
Package Size
Android file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
markmur
force-pushed
the
android-none-log-level
branch
from
July 14, 2026 08:00
1054096 to
b010e3d
Compare
kieran-osgood-shopify
approved these changes
Jul 14, 2026
markmur
force-pushed
the
swift-canonical-log-levels
branch
from
July 14, 2026 08:22
20ac9d3 to
5d262ec
Compare
markmur
force-pushed
the
android-none-log-level
branch
from
July 14, 2026 08:22
b010e3d to
c22b498
Compare
markmur
force-pushed
the
swift-canonical-log-levels
branch
from
July 14, 2026 08:48
5d262ec to
9052ad2
Compare
markmur
force-pushed
the
android-none-log-level
branch
from
July 14, 2026 08:48
c22b498 to
d2ad5fe
Compare
markmur
force-pushed
the
swift-canonical-log-levels
branch
from
July 14, 2026 08:59
9052ad2 to
d825200
Compare
markmur
force-pushed
the
android-none-log-level
branch
from
July 14, 2026 08:59
d2ad5fe to
efee365
Compare
kiftio
approved these changes
Jul 14, 2026
markmur
force-pushed
the
swift-canonical-log-levels
branch
from
July 14, 2026 10:03
d825200 to
abd1ba4
Compare
markmur
force-pushed
the
android-none-log-level
branch
from
July 14, 2026 10:03
efee365 to
378ab6c
Compare
Contributor
Author
markmur
changed the base branch from
swift-canonical-log-levels
to
graphite-base/442
July 14, 2026 11:15
Add a NONE case to LogLevel and gate LogWrapper.e() (both overloads) on it, so errors can be fully silenced. Previously e() always emitted regardless of log level. Regenerate the public API baseline.
markmur
force-pushed
the
android-none-log-level
branch
from
July 14, 2026 11:34
378ab6c to
0c997ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Completes the canonical
LogLevelset by adding aNONEcase, so errors can be fully silenced.LogLevelis nowDEBUG, WARN, ERROR, NONE(ordered, most to least verbose).LogWrapper.e()overloads on!= NONE— previouslye()always emitted regardless of level.WARN.Threshold
logLevelDEBUGWARN(default)ERRORNONEUsage