[Refactor] Collapse dual terminal PR status writes#270
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Refactor] Collapse dual terminal PR status writes#270roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
1 minor item to verify. See task The refactor is clean and behavior-preserving for the awaited providers (GitLab, Gitea, Bitbucket, Azure DevOps). Provider tests and the new SDK helper test pass.
Reviewed 6724694 |
Contributor
|
Thank you for your contribution! Before we can merge this pull request, we need you to sign our Contributor License Agreement. You can sign it by posting the comment below. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Merged and closed pull-request webhooks no longer run two copy-pasted side effects in every source-control provider. They call one SDK helper that updates the linked
task_pull_requestsrow and then records task-history best-effort with a single place for actor, title, URL, and error logging. GitHub, GitLab, Gitea, Bitbucket, and Azure DevOps terminal handlers were migrated, and provider tests now assert the unified call.Why this change was made
Provider closed/merged paths all paired
updateTaskPrStatuswithrecordPrStatusChangeInTaskHistorybehind nearly identical non-throwing wrappers. That dual write forked as providers grew and made it easy for one side effect to drift without the other.Impact
No intentional product behavior change for users. Terminal PR status still updates the tracked PR row and still lands in task history when history writing succeeds; history failures remain best-effort and non-throwing, while awaited providers still surface status-update failures. New providers only need to pass event facts into the shared helper.