[Fix] CLA check fails on Roomote-authored pull requests#273
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Fix] CLA check fails on Roomote-authored pull requests#273roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Roomote automation commits as the `roomote` GitHub user, which does not match the existing `*[bot]` allowlist pattern and fails CLA checks on automation-authored PRs.
Contributor
Author
Contributor
|
Thank you for your contribution! Before we can merge this pull request, we need you to sign our Contributor License Agreement. You can sign it by posting the comment below. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal CI fix for CLA Assistant failures on Roomote automation-authored PRs (default-branch recheck run 29238207369; same signature on PR 272 and PR 270). No separate tracking issue.
Why this PR exists
What changed
CLA Assistant failed on Roomote-authored PRs because commits are authored by the GitHub user
roomote, which did not match the bot-only allowlist pattern*[bot]. The workflow allowlist now includesroomotewhile keeping that bot pattern for other automation identities.How it was tested
roomote,*[bot].roomote(User, not bot), that identity is not incla-signatures, and that CLA had been failing with “Committers of Pull Request have to sign the CLA.”develop, recheck existing failing automation PRs.Impact
No product behavior change. Once on the default branch that CLA Assistant reads, Roomote automation-authored PRs stop failing the CLA check solely because of the first-party
roomotecommit identity. External human contributors remain subject to CLA as before.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset