Skip to content

[Fix] CLA check fails on Roomote-authored pull requests#273

Draft
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/cla-allowlist-roomote-27qptz6t6vyn3
Draft

[Fix] CLA check fails on Roomote-authored pull requests#273
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/cla-allowlist-roomote-27qptz6t6vyn3

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Created by Roomote. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

Internal CI fix for CLA Assistant failures on Roomote automation-authored PRs (default-branch recheck run 29238207369; same signature on PR 272 and PR 270). No separate tracking issue.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

CLA Assistant failed on Roomote-authored PRs because commits are authored by the GitHub user roomote, which did not match the bot-only allowlist pattern *[bot]. The workflow allowlist now includes roomote while keeping that bot pattern for other automation identities.

How it was tested

  • Parsed the updated CLA workflow YAML and confirmed the allowlist value is exactly roomote,*[bot].
  • Confirmed against live GitHub data that Roomote PR commits use login roomote (User, not bot), that identity is not in cla-signatures, and that CLA had been failing with “Committers of Pull Request have to sign the CLA.”
  • End-to-end CLA Assistant re-run needs GitHub PR events against the workflow on the default branch, so it was not exercised here; after merge to develop, recheck existing failing automation PRs.

Impact

No product behavior change. Once on the default branch that CLA Assistant reads, Roomote automation-authored PRs stop failing the CLA check solely because of the first-party roomote commit identity. External human contributors remain subject to CLA as before.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

Roomote automation commits as the `roomote` GitHub user, which does not
match the existing `*[bot]` allowlist pattern and fails CLA checks on
automation-authored PRs.
@roomote-roomote

roomote-roomote Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. This one-line change correctly allowlists the roomote committer identity in CLA Assistant while keeping the *[bot] pattern for other automation. See task

Reviewed fb29bac

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Before we can merge this pull request, we need you to sign our Contributor License Agreement. You can sign it by posting the comment below.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant