Repository navigation
fix: align session contracts and stop terminated Thread subscriptions - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Align the existing Forward/Managed SDK contracts with the official QCA documentation reviewed on 2026-11-03. This adds typed Forward Session budgets and model overrides, approval evaluation details and Environment startup scripts; it fixes the language-specific gaps documented below. No HTTP endpoints or version numbers change.
Forward and Managed approval results now return strings. Thread resumable streams stop after Thread termination while Session subscriptions keep running when a child Thread ends. Both sync and async paths are covered. Existing Java Credits, model speed, Memory version/redacted and Vault credential accessors already match the other SDK updates.
Validation
JDK 8 and 17:
./mvnw -B -ntp clean install(1,255 SDK tests per JDK),./mvnw -B -ntp -f examples/pom.xml clean verify(76 independent consumer tests per JDK), andpython3 .github/scripts/check_package.pypassed.make qualitypassed on JDK 17. CI will additionally cover JDK 11/21/25. No version change is included, so the POM version checklist is not applicable.Compatibility
SessionEvent.evaluatedPermission() now returns String instead of Map in both layers. Use Forward evaluation().evaluatedPermission() for optional detailed decisions.
Budget/model omission and null semantics, cumulative usage consumption, and migration details are in CHANGELOG.md. A pre-1.0 minor release is required for the incompatible type changes.
Contract sources