Skip to content

style: apply cargo fmt#5981

Merged
davidhewitt merged 4 commits intoPyO3:mainfrom
winstxnhdw:fix/format
Apr 17, 2026
Merged

style: apply cargo fmt#5981
davidhewitt merged 4 commits intoPyO3:mainfrom
winstxnhdw:fix/format

Conversation

@winstxnhdw
Copy link
Copy Markdown
Contributor

@winstxnhdw winstxnhdw commented Apr 16, 2026

Blocking #5894

LilyFirefly
LilyFirefly reviewed Apr 17, 2026
View reviewed changes
Comment thread newsfragments/5981.changed.md Outdated
@LilyFirefly LilyFirefly added the CI-skip-changelog Skip checking changelog entry label Apr 17, 2026
@davidhewitt
Copy link
Copy Markdown
Member

davidhewitt commented Apr 17, 2026

Thanks for this. Will need to run nox -s update-ui-tests to get the UI tests green again too.

I'm having a quick look for options to pin the stable rust on CI so that we don't get everything automatically failing as soon as the new toolchain drops (we've had this status quo for a while but it's probably time to make it a bit more automated).

@winstxnhdw
Copy link
Copy Markdown
Contributor Author

winstxnhdw commented Apr 17, 2026

Thanks for this. Will need to run nox -s update-ui-tests to get the UI tests green again too.

I'm having a quick look for options to pin the stable rust on CI so that we don't get everything automatically failing as soon as the new toolchain drops (we've had this status quo for a while but it's probably time to make it a bit more automated).

Should it be done in this PR?

@davidhewitt davidhewitt enabled auto-merge April 17, 2026 07:22
@winstxnhdw winstxnhdw mentioned this pull request Apr 17, 2026
Closed
auto-merge was automatically disabled April 17, 2026 07:51

Head branch was pushed to by a user without write access

@davidhewitt davidhewitt enabled auto-merge April 17, 2026 08:01
@davidhewitt davidhewitt added this pull request to the merge queue Apr 17, 2026
Merged via the queue into PyO3:main with commit a2fd837 Apr 17, 2026
46 checks passed
@winstxnhdw winstxnhdw deleted the fix/format branch April 17, 2026 09:29
davidhewitt pushed a commit to davidhewitt/pyo3 that referenced this pull request May 1, 2026
@winstxnhdw @davidhewitt
style: apply cargo fmt (PyO3#5981)
aa99ebc 
* style: apply cargo fmt

* Delete newsfragments/5981.changed.md

* chore: update ui tests

* chore: update ui tests again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LilyFirefly LilyFirefly LilyFirefly left review comments

Assignees

No one assigned

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@winstxnhdw @davidhewitt @LilyFirefly