Skip to content

chore: pin rustc version with rust-toolchain#5982

Closed
winstxnhdw wants to merge 3 commits intoPyO3:mainfrom
winstxnhdw:ci/toolchain
Closed

chore: pin rustc version with rust-toolchain#5982
winstxnhdw wants to merge 3 commits intoPyO3:mainfrom
winstxnhdw:ci/toolchain

Conversation

@winstxnhdw
Copy link
Copy Markdown
Contributor

@winstxnhdw winstxnhdw commented Apr 17, 2026

We can pin the Rust toolchain version with a rust-toolchain.toml to avoid situations like #5981

@winstxnhdw
Copy link
Copy Markdown
Contributor Author

CI should fail until #5981 is merged and this PR is rebased.

Comment thread rust-toolchain.toml Outdated
@bschoenmaeckers bschoenmaeckers added the CI-skip-changelog Skip checking changelog entry label Apr 17, 2026
@winstxnhdw
Copy link
Copy Markdown
Contributor Author

It seems like it is conflicting with the dtolnay@rust-toolchain action. Maybe we should just pin the action instead?

@davidhewitt
Copy link
Copy Markdown
Member

I would prefer to not have the toolchain file, see Rust-for-CPython/cpython#4 (comment) which matches my sentiment about having the project pull a toolchain locally be annoying

Pinning CI with an automated upgrade PR mechanism seems like my preferred approach

@winstxnhdw
Copy link
Copy Markdown
Contributor Author

winstxnhdw commented Apr 17, 2026

Okay, I gave a few attempts but I think this will need quite an extensive change. My plan was to interpolate all the Rust toolchain versions in ci.yml using the repository variables. Then with another scheduled workflow, we can check for the latest toolchain releases and compare it with the current toolchain version. Afterwards, we turn ci. yml into a workflow_call that will accept the toolchain version as an input. This is needed so that we can test whether the new toolchain version successfully builds. If all is well, we can use the gh cli to update the toolchain version and submit a PR.

It's quite involved so I think I will close this PR for now and work on this later or after some more discussion.

@winstxnhdw winstxnhdw closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants