Repository navigation
Add generic slmsuite SLM actuator (simulated, Meadowlark, Holoeye) - #2
Merged
Merged
Conversation
…eye variants Rename the plugin template to pymodaq_plugins_slmsuite and add a DAQ_Move family driving any slmsuite SLM with the same phase / grey level interface as the Holoeye plugin and the BeamShaping mock shaper. Tested against the slmsuite simulated SLM only. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
opencv-python sets QT_QPA_PLATFORM_PLUGIN_PATH to its own bundled Qt plugins when imported; creating the QApplication afterwards aborted with PyQt5. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of the slmsuite integration for BeamShaping: a PyMoDAQ plugin giving access to the SLMs supported by slmsuite.
pymodaq_plugins_slmsuiteand removes the unused template modules (viewers, extension, app).DAQ_Move_SlmsuiteBase: common actuator. The target is a 2D array of the SLM shape (or one value spread over the SLM), displayed as a phase in radians (converted to grey levels by slmsuite: wrapping, LUT, wavefront correction) or as raw grey levels (Input as grey levelssetting oras_grey_levelsdata attribute, asDataShaperof BeamShaping does). Same interface aspymodaq_plugins_holoeyeand the BeamShaping mock Shaper.Slmsuite(generic: SLM type + constructor arguments as a Python literal dict, parsed withast.literal_eval),SlmsuiteSimulated,SlmsuiteMeadowlark(win32 only),SlmsuiteHoloeye.hardware/slm_controller.py: thin wrapper over the slmsuite classes (lazy vendor imports, easy to fake in tests).check_pluginpass, both against the slmsuiteSimulatedSLMand a fake controller.Not validated
Nothing was tested on a real SLM. Meadowlark (then Holoeye) will be tested on hardware by the maintainer before merge.
Notes for review
resources/config_template.toml.Generated by Claude Code