Repository navigation
Add slmsuite Hologram algorithm for BeamShaping - #3
Merged
Merged
Conversation
Registered through the pymodaq_plugins_beam_shaping.algorithms entry point (added by the metadata hook), with a beamshaping extra and tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
seb5g
marked this pull request as ready for review
October 25, 2026 21:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SlmsuiteHologramalgorithm (GS, WGS-Leonardo/Kim/Nogrette/Wu/tanh) wrappingslmsuite.holography.algorithms.Hologram, usable in the BeamShaping extension. The optimizer state is kept from step to step and restarts when the input, target or initial phase changes. CG is not exposed yet.pymodaq_plugins_beam_shaping.algorithmsentry point, added inhatch_build.pyafter the template hook (the template generatesentry-points, so it can't be declared statically inpyproject.toml; this deviates from the "leave as is" part of the template).beamshapingextra, README section, tests (methods vs slmsuite defaults, convergence on a 4-spot target for each method, restart behaviour, entry-point discovery).Stacked on #2 (base is the phase 1 branch). Needs PyMoDAQ/pymodaq_plugins_beam_shaping#57 (entry-point discovery) to be found at runtime.
Tested with 42 passed locally (simulated SLM, offscreen Qt).
Generated by Claude Code