Repository navigation
Conversation
…and the deprecations - require pymodaq 5.3.x explicitly (>=5.3.2,<5.4), python >= 3.10 - AlgoApp: module_and_data_saver is a property of CustomApp, override it with a setter - FieldLoaderApp: do not trigger the legend of the 2D viewers (paint error in pymodaq_gui 5.3, crash with PySide6), use the ROI of the ROIMeta for the mask, detach widgets of the previous loader without processEvents - calibrating: no more import of the removed ScanManager.get_scanner_folder (calibration scan entry to be redone) - _epsilons, current_value, setup_docks_and_widgets, pymodaq.utils.custom_ext, load_dashboard_with_arguments - tests creating the CustomApp and the extension Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
…st import At import time pytest-xvfb has not started its display yet, which aborted pytest on the Linux CI jobs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit of the
CustomApp/CustomExtof the package against PyMoDAQ 5.3.8 (see the audit document shared in the project). The BeamShaping extension did not even start.pyproject.toml:pymodaq,pymodaq_utils,pymodaq_gui,pymodaq_datanow require the 5.3.x series explicitly (<5.4),requires-python >= 3.10, build requirementpymodaq_utils>=5.3.6.AlgoAppassignedmodule_and_data_saver, a read-only property ofCustomAppin 5.3 (property with a setter now).utilities/calibrating.pyimportedpymodaq.extensions.scan.scan_manager, which no longer exists, at import time: the call is removed (see below).LegendItempaint aUniformImageItemthat has nooptsin pymodaq_gui 5.3 (paint error, native crash with PySide6): not triggered anymore. The mask now uses the ROI of theROIMeta(.roi). The widgets of the previous loader are detached withoutprocessEvents().check_plugin:_epsilons,current_value,setup_docks->setup_docks_and_widgets,pymodaq.utils.custom_ext,load_dashboard_with_argumentsin themain()functions.tests/test_custom_apps.py: createsFieldLoaderApp(loaders, mask),AlgoApp,Correctionand the extension on an empty Dashboard.tests/conftest.pyimportscv2first (its wheel setsQT_QPA_PLATFORM_PLUGIN_PATH, which breaks PyQt5) and creates the QApplication withmkQApp(the apps read the theme).Not done / to validate
BeamShapingCalibration):resources/holography_calibration.xmlis a scan configuration of the former scanner manager and has to be rewritten as an entry of the 5.3 scan manager. The calibration is therefore still not usable; a TODO documents it.Generated by Claude Code