Repository navigation
Keep 5.0.x compatible with pymodaq 5.2 - #59
Merged
Merged
Conversation
…d the quit_fun hook The floors raised to 5.3 by the template alignment are back to pymodaq>5.2.8 and pymodaq_gui>5.0.11. pymodaq < 5.3 only calls quit_fun, so it is defined (calling _quit_fun) when CustomExt has no _quit_fun. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5.0.x stays the branch for pymodaq <= 5.2 (the 5.3 alignment goes to
5.3.x, see #58).pyproject.toml: back topymodaq>5.2.8andpymodaq_gui>5.0.11(the floors raised to 5.3 by Follow the plugin template: acceptance tests, shared workflows, AGENTS.md #56 would prevent installing it with pymodaq 5.2).BeamShaping: pymodaq < 5.3 only callsquit_fun, so the layout was no longer saved and the docks no longer closed since Follow the plugin template: acceptance tests, shared workflows, AGENTS.md #56 renamed it_quit_fun.quit_funis defined (calling_quit_fun) only whenCustomExthas no_quit_fun, so pymodaq 5.3 still passes the PMQ339 rule of the acceptance tests.Checked
FieldLoaderApp(loaders, masks, saving),AlgoApp,Correction, and the extension is created on an empty Dashboard; closing it calls_quit_fun.Generated by Claude Code