Skip to content

Fix weighted trade search repeating when exactly 10 results match #10370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcagnion wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −1
Open

Fix weighted trade search repeating when exactly 10 results match #10370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Classes/TradeQueryRequests.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ function TradeQueryRequestsClass:SearchWithQueryWeightAdjusted(realm, league, qu
if errMsg and ((errMsg == "No Matching Results Found" and currentRecursion >= maxRecursion) or errMsg ~= "No Matching Results Found") then
return callback(nil, errMsg)
end
if (response.total > self.maxFetchPerSearch and response.total < 10000) or currentRecursion >= maxRecursion then
if (response.total >= self.maxFetchPerSearch and response.total < 10000) or currentRecursion >= maxRecursion then
-- Search not clipped or max recursion reached, fetch results and finalize
if previousSearchItems and self.maxFetchPerSearch > response.total then
-- Not enough items in the last search, fill results from previous search
Expand Down
Loading