Conversation
A search returning exactly maxFetchPerSearch results matched no finalize condition and was treated as clipped: the threshold was raised, then halved again, until the recursion limit. A full result window is not clipped, so fetch it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
When a weighted trade search returns exactly 10 results,
SearchWithQueryWeightAdjustedtreats it as clipped. It raises the minimum weight, gets fewer than 10 results, lowers the weight again, and repeats until the recursion limit of 5 searches. The final list is correct, but up to 4 extra searches and their fetches count against the trade API rate limit. With a minimum weight of 0 this is pointless, since the whole market already fits in those 10 results.10 results fill every result slot, which is what #5526 aims for, so the search now stops there (
>becomes>=).Steps taken to verify a working solution: