Repository navigation
Show dialog and filter button labels in sentence case - #64
Merged
Merged
Conversation
hameno
enabled auto-merge (rebase)
October 9, 2026 20:55
hameno
force-pushed
the
feature/dialog_button_sentence_case
branch
from
October 9, 2026 20:56
8bb744c to
475a86f
Compare
hameno
changed the title
The package filter dialogs and the profile editor's add-filter buttons
upper-cased their labels in code ("CANCEL", "ADD", "YES", "CLOSE",
"PACKAGE NAME", "APP SIGNATURE"), while the rest of the app uses the
string resources as written. They now use the strings unchanged, and
add_package_name reads "Package name" instead of "package name".
Compose UI tests also run as Robolectric unit tests now, so the labels
are covered by DialogButtonLabelTest and FilterTypeLabelTest.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hameno
force-pushed
the
feature/dialog_button_sentence_case
branch
from
October 10, 2026 13:07
01be8ee to
a98ba8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package filter dialogs (delete, add package name, add app signature, info, preview) and the profile editor's add-filter buttons upper-cased their labels in code (
CANCEL,ADD,YES,CLOSE,PACKAGE NAME,APP SIGNATURE), while the rest of the app uses the string resources as written. They now use the strings unchanged.add_package_namenow reads "Package name" instead of "package name". This also fixes the filter info dialog's title for package-name filters. German was already right.DialogButtonLabelTestandFilterTypeLabelTestrender the dialogs and the editor under Robolectric and check the labels. For that,app/build.gradleaddstestImplementation(composeBom)andui-test-junit4to unit tests, and the composables'viewStateoverloads areinternalinstead ofprivate.values-dehas nocanceloryestranslations, so German users still see English for those two.🤖 Generated with Claude Code