Repository navigation
Move hard-coded dialog strings into string resources - #66
Merged
Merged
Conversation
hameno
force-pushed
the
feature/dialog_string_resources
branch
from
October 10, 2026 13:08
2070a32 to
47f2650
Compare
The analytics opt-in dialog and snackbar, the delete-profile and profile-in-use dialogs, the color picker title, the list preference default title, the filter dialogs' error line and the activity chooser's toast were hard-coded English. They now use string resources with German translations. The English text is unchanged. The delete-profile dialog is extracted into DeleteProfileDialog so DialogStringResourcesTest can render it alongside the others. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The delete-profile, profile-in-use and color selection dialogs now use the delete_profile, error_profile_in_use and pick_widget_color strings, which were already defined (and translated) but unused, instead of the generic "Confirm", "Error" and "Select color". Those three strings are removed again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hameno
force-pushed
the
feature/dialog_string_resources
branch
from
October 10, 2026 13:18
47f2650 to
ff9a5ad
Compare
hameno
enabled auto-merge (rebase)
October 10, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #64 and #65. This branch is based on #65 with #64 merged in, so until both land the diff also shows their commits. Merge them first.
The following were hard-coded English and are now string resources with German translations. The English text is unchanged.
The delete-profile dialog moves out of
WidgetProfilesScreenintoDeleteProfileDialog, unchanged in behavior.DialogStringResourcesTestrenders each dialog under a German locale and checks the German text. #65'sTranslationCompletenessTestcovers the snackbar and toast strings.Not included: "Play Store" and "GitHub" on the About screen stay hard-coded as product names.
Titles: three dialogs now use the descriptive strings that were already defined and translated but unused: the delete-profile dialog uses
delete_profile("Delete profile?"), the profile-in-use error useserror_profile_in_use, and the color picker usespick_widget_color. They replace the generic "Confirm", "Error" and "Select color".🤖 Generated with Claude Code