Adding new Watcher's Eye variants#935
Open
Wires77 wants to merge 14 commits intoOpenarl:devfrom
Wires77:dev
Open
Adding new Watcher's Eye variants#935Wires77 wants to merge 14 commits intoOpenarl:devfrom Wires77:dev
Wires77 wants to merge 14 commits intoOpenarl:devfrom
Wires77:dev
Conversation
…s disabled for other items while I figure out how to hide it and dynamically move the other content around
Open
Contributor
|
When editing a gem other than Watcher's Eye,
|
…re is a 'None' variant instead for the third mod
Author
|
In the latest commit I just removed that box in favor of a "None" variant for the third watcher's eye mod. Thanks for pointing it out though. |
Merging from upstream
Update from upstream
This was referenced Sep 19, 2018
Merge from upstream
This was referenced Mar 19, 2019
|
is there an idea on when this pull request will be merged? |
|
@Openarl I know you're super busy with the Blight release at the moment, but I wanted to put this back on your radar. From my perspective this is a fairly low-risk and high-value change that many users would really appreciate. Is there more to be done here or does it just need a keen review from a core maintainer? Anything I can do to help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I copied these from the wiki, and for some reason the diff is showing the addition and removal of almost all of them.
I also added a checkbox to differentiate between a jewel from Uber Elder and one from just regular Elder. I wasn't able to figure out how to hide the checkbox for other uniques without my code removing all of the variant section or leaving a blank, so I just disabled it to get this in. I can remove that commit or at least the checkbox after this weekend if you'd rather wait on that piece until later.