-
Notifications
You must be signed in to change notification settings - Fork 1k
#547 Implementing 3.0 Shock Effect and Duration in Calcs Tab #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Artanys
wants to merge
249
commits into
Openarl:dev
Choose a base branch
from
Artanys:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
249 commits
Select commit
Hold shift + click to select a range
1b08f28
Update manifest for release
287b5ca
Oops
0277ae9
Update manifest for release
6b2a747
Fix manifest
4ce0db1
Merge remote-tracking branch 'origin/dev'
7835cc8
Merge remote-tracking branch 'origin/dev'
ff140b0
Merge remote-tracking branch 'origin/dev'
d744d18
Merge remote-tracking branch 'origin/dev'
1027a19
Merge remote-tracking branch 'origin/dev'
0ce2103
Merge remote-tracking branch 'origin/dev'
231ac39
Merge remote-tracking branch 'origin/dev'
e22173b
Merge remote-tracking branch 'origin/dev'
83d109c
Merge remote-tracking branch 'origin/dev'
62d2502
Merge remote-tracking branch 'origin/dev'
4ff5a88
Merge remote-tracking branch 'origin/dev'
022d2c2
Merge remote-tracking branch 'origin/dev'
00ab939
Merge remote-tracking branch 'origin/dev'
719f1ce
Merge remote-tracking branch 'origin/dev'
2737e9c
Merge remote-tracking branch 'origin/dev'
9d9be75
Merge remote-tracking branch 'origin/dev'
616a316
Merge remote-tracking branch 'origin/dev'
1407e3b
Merge remote-tracking branch 'origin/dev'
be5ff53
Merge remote-tracking branch 'origin/dev'
9e0c81c
Merge remote-tracking branch 'origin/dev'
8d9471d
Merge remote-tracking branch 'origin/dev'
6f824ff
Merge remote-tracking branch 'origin/dev'
f7ddc8b
Merge remote-tracking branch 'origin/dev'
8c9e2dc
Merge remote-tracking branch 'origin/dev'
f575176
Merge remote-tracking branch 'origin/dev'
f5395c0
Merge remote-tracking branch 'origin/dev'
478a998
Merge remote-tracking branch 'origin/dev'
8d92be1
Merge remote-tracking branch 'origin/dev'
f207803
Merge remote-tracking branch 'origin/dev'
3185983
Merge remote-tracking branch 'origin/dev'
fe98b7f
Merge remote-tracking branch 'origin/dev'
cd4c9df
Merge remote-tracking branch 'origin/dev'
9417fda
Merge remote-tracking branch 'origin/dev'
5a325e9
Merge remote-tracking branch 'origin/dev'
4fad6c6
Merge remote-tracking branch 'origin/dev'
0b54ce9
Merge remote-tracking branch 'origin/dev'
fd92056
Merge remote-tracking branch 'origin/dev'
ea05a57
Merge remote-tracking branch 'origin/dev'
2889121
Merge remote-tracking branch 'origin/dev'
93d76db
Merge remote-tracking branch 'origin/dev'
430dfda
Merge remote-tracking branch 'origin/dev'
6bebcf3
Merge remote-tracking branch 'origin/dev'
7889760
Merge remote-tracking branch 'origin/dev'
a88e4de
Merge remote-tracking branch 'origin/dev'
9eb54a5
Merge remote-tracking branch 'origin/dev'
9e83c11
Merge remote-tracking branch 'origin/dev'
9bb9e2f
Merge remote-tracking branch 'origin/dev'
05ca012
Merge remote-tracking branch 'origin/dev'
c6adda4
Merge remote-tracking branch 'origin/dev'
9e51e4c
Merge remote-tracking branch 'origin/dev'
4098fc4
Merge remote-tracking branch 'origin/dev'
44400ce
Merge remote-tracking branch 'origin/dev'
a2ce0eb
Merge remote-tracking branch 'origin/dev'
ab991de
Merge remote-tracking branch 'origin/dev'
5e23bac
Merge remote-tracking branch 'origin/dev'
bb10d8c
Merge remote-tracking branch 'origin/dev'
ccff578
Merge remote-tracking branch 'origin/dev'
f34453b
Merge remote-tracking branch 'origin/dev'
7b177fd
Merge remote-tracking branch 'origin/dev'
d4f9727
Merge remote-tracking branch 'origin/dev'
11fd81b
Merge remote-tracking branch 'origin/dev'
a1e892c
Merge remote-tracking branch 'origin/dev'
22857d5
Merge remote-tracking branch 'origin/dev'
6806942
Merge remote-tracking branch 'origin/dev'
7d490fc
Merge remote-tracking branch 'origin/dev'
f0fd93d
Merge remote-tracking branch 'origin/dev'
9b5d6c5
Merge remote-tracking branch 'origin/dev'
88a06c6
Merge remote-tracking branch 'origin/dev'
927bdb3
Merge remote-tracking branch 'origin/dev'
bf049ae
Merge remote-tracking branch 'origin/dev'
04ee1a0
Merge remote-tracking branch 'origin/dev'
2bba6f6
Merge remote-tracking branch 'origin/dev'
9acd9d5
Merge remote-tracking branch 'origin/dev'
e5e4e3b
Merge remote-tracking branch 'origin/dev'
bb77493
Merge remote-tracking branch 'origin/dev'
9508883
Merge remote-tracking branch 'origin/dev'
6f1f9dd
Merge remote-tracking branch 'origin/dev'
479bbac
Merge remote-tracking branch 'origin/dev'
e1c1a8b
Merge remote-tracking branch 'origin/dev'
5f2ec59
Merge remote-tracking branch 'origin/dev'
3fd2428
Merge remote-tracking branch 'origin/dev'
7086714
Merge remote-tracking branch 'origin/dev'
fdc1222
Merge remote-tracking branch 'origin/dev'
84e4b0d
Merge remote-tracking branch 'origin/dev'
Openarl 32b986c
Merge remote-tracking branch 'origin/dev'
Openarl cc31993
Merge remote-tracking branch 'origin/dev'
Openarl 657c1e2
Merge remote-tracking branch 'origin/dev'
Openarl a4d8157
Merge remote-tracking branch 'origin/dev'
Openarl 028b683
Merge remote-tracking branch 'origin/dev'
Openarl 9728c1a
Merge remote-tracking branch 'origin/dev'
Openarl 5295094
Merge remote-tracking branch 'origin/dev'
Openarl edc6aaf
Merge remote-tracking branch 'origin/dev'
Openarl b0abaa4
Merge remote-tracking branch 'origin/dev'
Openarl 0ffbdff
Merge remote-tracking branch 'origin/dev'
Openarl 6d567b8
Merge remote-tracking branch 'origin/dev'
Openarl ef0d890
Merge remote-tracking branch 'origin/dev'
Openarl 6b3b6e1
Merge remote-tracking branch 'origin/dev'
Openarl 9c80f7b
Merge remote-tracking branch 'origin/dev'
Openarl 4b6781b
Merge remote-tracking branch 'origin/dev'
Openarl 3fb906e
Merge remote-tracking branch 'origin/dev'
Openarl 1080c77
Merge remote-tracking branch 'origin/dev'
Openarl b02256e
Merge remote-tracking branch 'origin/dev'
Openarl 9b33d41
Merge remote-tracking branch 'origin/dev'
Openarl e821e62
Merge remote-tracking branch 'origin/dev'
Openarl 9d755e2
Merge remote-tracking branch 'origin/dev'
Openarl 11703ff
Merge remote-tracking branch 'origin/dev'
Openarl 94a14a9
Merge remote-tracking branch 'origin/dev'
Openarl abfac0f
Merge remote-tracking branch 'origin/dev'
Openarl a6c7b8d
Merge remote-tracking branch 'origin/dev'
Openarl 4a08d4a
Merge remote-tracking branch 'origin/dev'
Openarl 5d7053b
Merge remote-tracking branch 'origin/dev'
Openarl d27b9f1
Merge remote-tracking branch 'origin/dev'
Openarl 71c8063
Merge remote-tracking branch 'origin/dev'
Openarl 68a6915
Merge remote-tracking branch 'origin/dev'
Openarl f7d23db
Merge remote-tracking branch 'origin/dev'
Openarl c354c84
Merge remote-tracking branch 'origin/dev'
Openarl 01b7d5d
Merge remote-tracking branch 'origin/dev'
Openarl e6282e2
Merge remote-tracking branch 'origin/dev'
Openarl 03717af
Merge remote-tracking branch 'origin/dev'
Openarl 442a1a4
Merge remote-tracking branch 'origin/dev'
Openarl 74ced69
Merge remote-tracking branch 'origin/dev'
Openarl 710aa4f
Merge remote-tracking branch 'origin/dev'
Openarl 25521a6
Merge remote-tracking branch 'origin/dev'
Openarl 1df6b6a
Merge remote-tracking branch 'origin/dev'
Openarl 3a67b36
Merge remote-tracking branch 'origin/dev'
Openarl e37b8ad
Merge remote-tracking branch 'origin/dev'
Openarl d94a092
Merge remote-tracking branch 'origin/dev'
Openarl 2310232
Merge remote-tracking branch 'origin/dev'
Openarl 462b3c1
Merge remote-tracking branch 'origin/dev'
Openarl 6bf718d
Merge remote-tracking branch 'origin/dev'
Openarl cfd81be
Merge remote-tracking branch 'origin/dev'
Openarl fcbeb93
Merge remote-tracking branch 'origin/dev'
Openarl 6991d95
Merge remote-tracking branch 'origin/dev'
Openarl cfbf0f1
Merge remote-tracking branch 'origin/dev'
Openarl 15f5696
Merge remote-tracking branch 'origin/dev'
Openarl 549c040
Merge remote-tracking branch 'origin/dev'
Openarl 9dd6ffc
Merge remote-tracking branch 'origin/dev'
Openarl c1155ff
Merge remote-tracking branch 'origin/dev'
Openarl 3c29de5
Merge remote-tracking branch 'origin/dev'
Openarl 7f2f570
Merge remote-tracking branch 'origin/dev'
Openarl 42eea34
Merge remote-tracking branch 'origin/dev'
Openarl e1f3ecc
Merge remote-tracking branch 'origin/dev'
Openarl f0c57f0
Merge remote-tracking branch 'origin/dev'
Openarl a233c21
Merge remote-tracking branch 'origin/dev'
Openarl 055b220
Merge remote-tracking branch 'origin/dev'
Openarl 97c2673
Merge remote-tracking branch 'origin/dev'
Openarl c1c9e37
Merge remote-tracking branch 'origin/dev'
Openarl e2e9a3e
Merge remote-tracking branch 'origin/dev'
Openarl b4d7f73
Merge remote-tracking branch 'origin/dev'
Openarl 9dae451
Merge remote-tracking branch 'origin/dev'
Openarl 056b01a
Merge remote-tracking branch 'origin/dev'
Openarl b66abcc
Merge remote-tracking branch 'origin/dev'
Openarl f0b977f
Merge remote-tracking branch 'origin/dev'
Openarl 4c0a8d2
Merge remote-tracking branch 'origin/dev'
Openarl 38dd3a7
Merge remote-tracking branch 'origin/dev'
Openarl c7f9713
Merge remote-tracking branch 'origin/dev'
Openarl d7a87fe
Merge remote-tracking branch 'origin/dev'
Openarl 0850695
Merge remote-tracking branch 'origin/dev'
Openarl 4905fce
Merge remote-tracking branch 'origin/dev'
Openarl 039ae45
Merge remote-tracking branch 'origin/dev'
Openarl 577f5e1
Merge remote-tracking branch 'origin/dev'
Openarl ea42a81
Merge remote-tracking branch 'origin/dev'
Openarl f7a2b11
Merge remote-tracking branch 'origin/dev'
Openarl dc223df
Merge remote-tracking branch 'origin/dev'
Openarl 52d1e41
Merge remote-tracking branch 'origin/dev'
Openarl b7afb7e
Merge remote-tracking branch 'origin/dev'
Openarl bc8b037
Merge remote-tracking branch 'origin/dev'
Openarl 8cb7de2
Merge remote-tracking branch 'origin/dev'
Openarl 671f26c
Merge remote-tracking branch 'origin/dev'
Openarl 4557e4e
Merge remote-tracking branch 'origin/dev'
Openarl 2c1c001
Merge remote-tracking branch 'origin/dev'
Openarl 27f3920
Merge remote-tracking branch 'origin/dev'
Openarl 10ede16
Merge remote-tracking branch 'origin/dev'
Openarl faa8d78
Merge remote-tracking branch 'origin/dev'
Openarl 628b768
Merge remote-tracking branch 'origin/dev'
Openarl 259cb62
Merge remote-tracking branch 'origin/dev'
Openarl e9ad875
Merge remote-tracking branch 'origin/dev'
Openarl 47a3c69
Merge remote-tracking branch 'origin/dev'
Openarl 4f79570
Merge remote-tracking branch 'origin/dev'
Openarl cbc7b2a
Merge remote-tracking branch 'origin/dev'
Openarl ee220a7
Merge remote-tracking branch 'origin/dev'
Openarl 7aa2ff1
Merge remote-tracking branch 'origin/dev'
Openarl 9502e2a
Merge remote-tracking branch 'origin/dev'
Openarl 6a773ad
Merge remote-tracking branch 'origin/dev'
Openarl 1cf26d6
Merge remote-tracking branch 'origin/dev'
Openarl 1871f6f
Merge remote-tracking branch 'origin/dev'
Openarl dea6982
Merge remote-tracking branch 'origin/dev'
Openarl 7c43326
Merge remote-tracking branch 'origin/dev'
Openarl 58ea211
Merge remote-tracking branch 'origin/dev'
Openarl 5a46a76
Merge remote-tracking branch 'origin/dev'
Openarl 329bcb4
Merge remote-tracking branch 'origin/dev'
Openarl 65075a9
Merge remote-tracking branch 'origin/dev'
Openarl 0d49054
Merge remote-tracking branch 'origin/dev'
Openarl a5f6c4b
Merge remote-tracking branch 'origin/dev'
Openarl 9fa334b
Merge remote-tracking branch 'origin/dev'
Openarl 6d9f30c
Update shield.lua
twiz-git bc58be5
Merge pull request #715 from twiz-ahk/patch-2
Openarl c434635
Revert "Update shield.lua"
Openarl f27bfa2
Merge remote-tracking branch 'origin/dev'
Openarl 963e940
Merge remote-tracking branch 'origin/dev'
Openarl acd30d8
Merge remote-tracking branch 'origin/dev'
Openarl 8f7ed3f
Merge remote-tracking branch 'origin/dev'
Openarl 49daa8b
Merge remote-tracking branch 'origin/dev'
Openarl 47b96cd
Merge remote-tracking branch 'origin/dev'
Openarl 2468c47
Merge remote-tracking branch 'origin/dev'
Openarl 30b53b3
Merge remote-tracking branch 'origin/dev'
Openarl 228db93
Merge remote-tracking branch 'origin/dev'
Openarl 34f35a5
Merge remote-tracking branch 'origin/dev'
Openarl b08fec6
Merge remote-tracking branch 'origin/dev'
Openarl 76e9989
Merge remote-tracking branch 'origin/dev'
Openarl 3b3bf78
Merge remote-tracking branch 'origin/dev'
Openarl 913922c
Merge remote-tracking branch 'origin/dev'
Openarl 8a9a79d
Merge remote-tracking branch 'origin/dev'
Openarl a4de7ce
Merge remote-tracking branch 'origin/dev'
Openarl e7c4d8e
Merge remote-tracking branch 'origin/dev'
Openarl 6acff3a
Merge remote-tracking branch 'origin/dev'
Openarl 6773450
Merge remote-tracking branch 'origin/dev'
Openarl 7db3e69
Merge remote-tracking branch 'origin/dev'
Openarl dd7d48c
Merge remote-tracking branch 'origin/dev'
Openarl 017f422
Merge remote-tracking branch 'origin/dev'
Openarl f16c16a
Merge remote-tracking branch 'origin/dev'
Openarl 5cdcc7f
Merge pull request #1 from Openarl/dev
Artanys 9543aee
Merge remote-tracking branch 'origin/dev'
Openarl 0204009
Merge remote-tracking branch 'upstream/dev' into dev
Artanys 772454b
Merge remote-tracking branch 'origin/dev'
Openarl d515d4e
Merge remote-tracking branch 'origin/dev'
Openarl e1d6ea4
Merge remote-tracking branch 'origin/dev'
Openarl f3d1608
Merge branch 'master' into dev
Artanys db0e138
Implementing 3.0 Shock Effect & Duration
Artanys 1b927d0
Putting self shock duration back in
Artanys 98ae8a9
Merge remote-tracking branch 'origin/dev'
Openarl ccacc05
Merge remote-tracking branch 'origin/dev'
Openarl 1e3a1db
Merge remote-tracking branch 'origin/dev'
Openarl 9288c58
Merge remote-tracking branch 'origin/dev'
Openarl cb6bd09
Merge remote-tracking branch 'origin/dev'
Openarl a48d9d6
Merge remote-tracking branch 'origin/dev'
Openarl ecc9429
Merge remote-tracking branch 'origin/dev'
Openarl 0768e42
Merge remote-tracking branch 'origin/dev'
Openarl e270cf9
Merge remote-tracking branch 'origin/dev'
Openarl 5e06240
Merge remote-tracking branch 'origin/dev'
Openarl 53b41a3
Merge pull request #2 from Openarl/master
Artanys d26fb89
Merge remote-tracking branch 'origin/dev'
Openarl ec2c275
Merge remote-tracking branch 'origin/dev'
Openarl 0b5fbf7
Merge pull request #3 from Openarl/master
Artanys 7826edf
Merge remote-tracking branch 'refs/remotes/origin/master' into dev
Artanys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't enemy modifiers and "self" modifiers multiplicative with each other? E.g.
20% increased shock durationandShocks last 20% longer(from the enemy POV) would result intotal duration = 1.2 * 1.2or am I misunderstanding where theSelfShockDurationcomes from? Can you give an example when enemies have that modifier?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing I could find was on Conductivity curse https://pathofexile.gamepedia.com/Conductivity
Hypothermia does something similar with it's quality modifier. It is also listed as SelfFreezeDuration in PoB.
SelfFreezeDuration and EnemyFreezeDuration are summed up in the offense calculation, not multiplied together. I think the difference would be if the enemy was also under the effect of Temporal Chains, which is a multiplier on the ailment duration (by nature of making time expire slower)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could also be that PoB is wrong and they should be multiplied :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is indeed applied by Conductivity then the calculation is correct.
I just thought that poe treats these things the same way it treats damage (i.e. damage dealt is multiplicative with damage taken) but looking at Maligaros Restraint it seems like durations are indeed additive.