Skip to content

#547 Implementing 3.0 Shock Effect and Duration in Calcs Tab#1024

Open
Artanys wants to merge 249 commits intoOpenarl:devfrom
Artanys:dev
Open

#547 Implementing 3.0 Shock Effect and Duration in Calcs Tab#1024
Artanys wants to merge 249 commits intoOpenarl:devfrom
Artanys:dev

Conversation

@Artanys
Copy link
Copy Markdown

@Artanys Artanys commented Jun 1, 2018

@Artanys
Copy link
Copy Markdown
Author

Artanys commented Jun 1, 2018

Not sure why all of those other merges were put in, my apologies

@Artanys Artanys changed the title Implementing 3.0 Shock Effect and Duration in Calcs Tab #547 Implementing 3.0 Shock Effect and Duration in Calcs Tab Jun 1, 2018
output.ShockDurationMod = 1 + modDB:Sum("INC", cfg, "EnemyShockDuration") / 100 + enemyDB:Sum("INC", nil, "SelfShockDuration") / 100

local baseShockDur = 2
local incDur = 1 + modDB:Sum("INC", cfg, "EnemyShockDuration") / 100 + enemyDB:Sum("INC", nil, "SelfShockDuration") / 100
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't enemy modifiers and "self" modifiers multiplicative with each other? E.g. 20% increased shock duration and Shocks last 20% longer (from the enemy POV) would result in total duration = 1.2 * 1.2 or am I misunderstanding where the SelfShockDuration comes from? Can you give an example when enemies have that modifier?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I could find was on Conductivity curse https://pathofexile.gamepedia.com/Conductivity
Hypothermia does something similar with it's quality modifier. It is also listed as SelfFreezeDuration in PoB.
SelfFreezeDuration and EnemyFreezeDuration are summed up in the offense calculation, not multiplied together. I think the difference would be if the enemy was also under the effect of Temporal Chains, which is a multiplier on the ailment duration (by nature of making time expire slower)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could also be that PoB is wrong and they should be multiplied :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is indeed applied by Conductivity then the calculation is correct.

I just thought that poe treats these things the same way it treats damage (i.e. damage dealt is multiplicative with damage taken) but looking at Maligaros Restraint it seems like durations are indeed additive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants