Skip to content

Add common SceneModifier support #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 6 commits into from
Jan 31, 2026

Add SceneActivationConditions

de87613
Select commit
Loading
Failed to load commit list.
Merged

Add common SceneModifier support #753

Add SceneActivationConditions
de87613
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 31, 2026 in 1s

26.79% (-0.10%) compared to ff45976

View this Pull Request on Codecov

26.79% (-0.10%) compared to ff45976

Details

Codecov Report

❌ Patch coverage is 0% with 160 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.79%. Comparing base (ff45976) to head (de87613).

Files with missing lines Patch % Lines
...ier/SceneModifier/EnvironmentWritingModifier.swift 0.00% 30 Missing ⚠️
...difier/SceneModifier/PreferenceSceneModifier.swift 0.00% 23 Missing ⚠️
...fier/SceneModifier/SceneActivationConditions.swift 0.00% 23 Missing ⚠️
Sources/OpenSwiftUI/App/Commands/Commands.swift 0.00% 20 Missing ⚠️
...ifier/SceneModifier/ValueActionSceneModifier.swift 0.00% 20 Missing ⚠️
.../SceneModifier/AppearanceActionSceneModifier.swift 0.00% 12 Missing ⚠️
...ources/OpenSwiftUI/App/Commands/CommandsList.swift 0.00% 8 Missing ⚠️
...re/Modifier/ViewModifier/ValueActionModifier.swift 0.00% 6 Missing ⚠️
...s/OpenSwiftUI/App/App/FinishLaunchTestAction.swift 0.00% 4 Missing ⚠️
...ifier/SceneModifier/EnvironmentSceneModifier.swift 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   26.89%   26.79%   -0.10%     
==========================================
  Files         637      642       +5     
  Lines       38767    38900     +133     
==========================================
- Hits        10425    10424       -1     
- Misses      28342    28476     +134

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov