Skip to content

Add common SceneModifier support#753

Merged
Kyle-Ye merged 6 commits intomainfrom
feature/scene_modifier
Jan 31, 2026
Merged

Add common SceneModifier support#753
Kyle-Ye merged 6 commits intomainfrom
feature/scene_modifier

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 31, 2026

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Jan 31, 2026
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

❌ Patch coverage is 0% with 160 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.79%. Comparing base (ff45976) to head (de87613).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ier/SceneModifier/EnvironmentWritingModifier.swift 0.00% 30 Missing ⚠️
...difier/SceneModifier/PreferenceSceneModifier.swift 0.00% 23 Missing ⚠️
...fier/SceneModifier/SceneActivationConditions.swift 0.00% 23 Missing ⚠️
Sources/OpenSwiftUI/App/Commands/Commands.swift 0.00% 20 Missing ⚠️
...ifier/SceneModifier/ValueActionSceneModifier.swift 0.00% 20 Missing ⚠️
.../SceneModifier/AppearanceActionSceneModifier.swift 0.00% 12 Missing ⚠️
...ources/OpenSwiftUI/App/Commands/CommandsList.swift 0.00% 8 Missing ⚠️
...re/Modifier/ViewModifier/ValueActionModifier.swift 0.00% 6 Missing ⚠️
...s/OpenSwiftUI/App/App/FinishLaunchTestAction.swift 0.00% 4 Missing ⚠️
...ifier/SceneModifier/EnvironmentSceneModifier.swift 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   26.89%   26.79%   -0.10%     
==========================================
  Files         637      642       +5     
  Lines       38767    38900     +133     
==========================================
- Hits        10425    10424       -1     
- Misses      28342    28476     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 7ddfbb6 into main Jan 31, 2026
7 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/scene_modifier branch January 31, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant