-
Notifications
You must be signed in to change notification settings - Fork 130
Adding relative model path to objects fixes #285 #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As a general point I think we should very carefully consider, whether talking about file paths in OSI is a good idea, since that presupposes that the is access to some common file system between different simulation models, which is not generally true (i.e. OSI-based simulations can run on distributed systems with no single system image). The most portable solution would be to transport all needed data during setup messages, and reference that data in the per time-step messages, however this might too complex a solution for 3.1.0 for now. A sort of middle ground would be to add fields like which would make the implementation-specific part of this information explicit, while still having a single place where to put this kind of information (instead of relying on implementation-specific field additions). And in future revisions it would be possible to add the setup machinery needed to transmit the 3d models during startup. |
|
Hi @pmai, |
|
@LudwigFriedmannBMW it could also be A name is both more specific and less specific, in my opinion, since it is not clear that it can/should be used to uniquely identify the model being referenced. So maybe |
Changing model_path to model_reference and altering documentation accordingly
|
After considering potential inconsistencies and/or ambiguousities in the implementation of the concept I postpone its implementation to OSI 4.0.0. A revision of the concept of object types could be helpful here. |
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR extends static objects and moving objects by a relative path to 3D models. This information can be used to model sensors that require precise geometrical information of their surrounding.