Add relative path of map in GroundTruth fixes #278 #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
added
FeatureRequest
ghost
mentioned this pull request
ghost
changed the title
ghost
mentioned this pull request
Contributor
|
See my comment on #284 on the issue of path names in OSI. |
Author
|
Hi @pmai, |
added 2 commits
November 5, 2018 14:40
Changing map_path to map_reference and alterating documentation accordingly
ghost
mentioned this pull request
ghost
approved these changes
Dec 14, 2018
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Considering the name of the field is "reference" and the note clarifies the usage - LGTM.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the GroundTruth by a relative path to a map.