-
Notifications
You must be signed in to change notification settings - Fork 130
World interface fixes #263 #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
World interface fixes #263 #244
Conversation
|
Thank you very much for this PR. We will look into it the earliest we can! |
|
Hello @ReinhardBiegelIntech, |
|
Hello @LudwigFriedmannBMW, Yes, the interface is meant to be an extension. Maybe the naming is a bit misleading. The name is just a first proposal originating from a short discussion between @CarloVanDriestenBMW and us at in-tech. We would like to use this interface the generate a different look at the ground truth - more from the perspective of a simulator than from a sensor. So why this extension to OSI? We'd like to re-use the common parts of OSI to allow simulation of OSI-compatible sensors, and at the same time use the same serialization/deserialization mechanisms to exchange the "extended" ground truth with other systems. I hope this will somwhat answer your question. Please feel free to ask for more information. |
|
For this to be included into OSI, the other components you mention would have to be specified, i.e. are the other components something that are not OpenPASS-specific? Only then placing this into OSI would make sense to me. Otherwise this can just be an OpenPASS-specific extension, living in OpenPASS, or am I missing something? |
|
@ReinhardBiegelIntech I had a talk with Arun Das and reviewed your changes again. In my opinion your changes are already accounted for since OSI 3.0.0? Could you clarify the need for the road types and why you need the logical structure of a road? please have a look at the new doxygen documentation of lanes. There are a lot of images explaining their usage. |
|
@CarloVanDriestenBMW Thanks for the update on this issue. We will have a more detailed look at the latest OSI changes as soon as possible. |
|
@ReinhardBiegelIntech it would be great to resolve this until end of this month if possible for you? |
|
I'm sorry that I wasn't able to answer your questions in time. We had a discussion about the future need for the WorldInterface today and decided not to pursue the integration of the WorldInterface into OSI anymore. So closing this PR was just in time. @pmai To answer your last question: Yes, the idea was that "other components" reside outside of openPASS. But we currently have no need for that anymore. |
I'd like to show our first proposal of an "world interface" to the community. Feedback and questions are welcome.