chore: sharpen syft-pr-review on proportionality, self-contained bullets and duplication - #9500
Merged
Merged
Conversation
…ets and duplication Five pieces of feedback, three of which were rules the skill already had and did not enforce hard enough, so they are sharpened rather than joined by a neighbour: - 'Length follows the code' becomes 'Length and position follow the code', and names the case that prompted it: mechanical cleanups get one short note at the end of their theme, never a bullet of their own. - 'Every bullet stands alone' now says a theme heading is a filing label, not context, so each bullet under it names its own subject. - The test-bullet rule splits: one keeps the shape, a new one requires the bullet to carry its own context and gives the before/after wording. Two additions to the code standards: duplicated functions or methods, and test names padded with articles and filler. The semicolon clause is dropped from the test rule because 'Scannable, not prose' already covers it. 193 lines / 1988 words / 19 rules, inside the budget.
This was referenced Sep 2, 2026
A skill edit landed on a working branch before it lands on the base rides along in that branch's PR diff, so the review would describe the reviewer's own tooling change as the PR author's work. Classify .claude/ as skippable, alongside lock files and generated data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five pieces of feedback on the review documents the skill produces. Three were rules the skill already had and did not enforce hard enough, so those are sharpened in place rather than joined by a near-duplicate neighbour.
Changes
Sharpened rules
Length follows the code→Length and position follow the code— makes explicit that word count and placement are both claims about how much something matters, and names the case that prompted it: mechanical cleanups (a moved import, a renamed local, a deleted comment) get one short note at the end of their theme, never a bullet of their own.Every bullet stands alone— now says a theme heading is a filing label, not context.B — Errors that name both sidestells a reader nothing about what raises the error or who the two sides are, so every bullet under it names its own subject.One test, one bulletsplits in two. The first keeps the shape; the newA test bullet carries its own contextrequires the condition, what runs, and what is then true, with the before/after wording: if a job list holds no unique name, the hint under the table renders a position instead of a name, not with no unique name left, the hint gives a position.New code standards
test_no_hint_when_do_owns_no_jobs, nottest_no_hint_when_the_do_owns_none_of_the_jobs.Removed
Scannable, not prosealready covers.Testing
193 lines / 1988 words / 19 rules, inside the 220 / 2200 / 20 budget.
pre-commitpasses. Regenerated the review on #9497 with it — see the comment there.