chore: land syft-pr-review skill update on this branch for testing - #9501
Merged
koenvanderveen merged 1 commit intoSep 2, 2026
Merged
Conversation
…ets and duplication Five pieces of feedback, three of which were rules the skill already had and did not enforce hard enough, so they are sharpened rather than joined by a neighbour: - 'Length follows the code' becomes 'Length and position follow the code', and names the case that prompted it: mechanical cleanups get one short note at the end of their theme, never a bullet of their own. - 'Every bullet stands alone' now says a theme heading is a filing label, not context, so each bullet under it names its own subject. - The test-bullet rule splits: one keeps the shape, a new one requires the bullet to carry its own context and gives the before/after wording. Two additions to the code standards: duplicated functions or methods, and test names padded with articles and filler. The semicolon clause is dropped from the test rule because 'Scannable, not prose' already covers it. 193 lines / 1988 words / 19 rules, inside the budget.
koenvanderveen
merged commit Sep 2, 2026
e6398dd
into
pjwerneck/fix-silent-failures
30 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the skill change from #9500 on this branch so the regenerated review can be produced with it. Skill files only — no product code.