Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Remove harcoded first value when getting all indicators #796

Merged
aHenryJard merged 3 commits into from
Jan 17, 2025
Merged

Remove harcoded first value when getting all indicators #796

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e97ada5
Remove harcoded first value when getting all indicators
jorgeacjitx Dec 11, 2024
9e3d406
Fixed format
jorgeacjitx Dec 11, 2024
629268b
Empty commit
jorgeacjitx Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pycti/entities/opencti_indicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ def list(self, **kwargs):
get_all = kwargs.get("getAll", False)
with_pagination = kwargs.get("withPagination", False)
with_files = kwargs.get("withFiles", False)
if get_all:
first = 100
Copy link
Member

@aHenryJard aHenryJard Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you take "first" value when present and keep 100 as default when "fisrt" is not present ?

Copy link
Contributor Author

@jorgeacjitx jorgeacjitx Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aHenryJard,
The param "first" has a default value of 500:

client-python/pycti/entities/opencti_indicator.py

Line 58 in 58a624b

first = kwargs.get("first", 500)

When the "get_all" param is true, it is still used for querying (L121):

client-python/pycti/entities/opencti_indicator.py

Lines 109 to 121 in 58a624b

if get_all:
final_data = []
data = self.opencti.process_multiple(result["data"]["indicators"])
final_data = final_data + data
while result["data"]["indicators"]["pageInfo"]["hasNextPage"]:
after = result["data"]["indicators"]["pageInfo"]["endCursor"]
self.opencti.app_logger.info("Listing Indicators", {"after": after})
result = self.opencti.query(
query,
{
"filters": filters,
"search": search,
"first": first,


self.opencti.app_logger.info(
"Listing Indicators with filters", {"filters": json.dumps(filters)}
Expand Down
Loading