Remove harcoded first value when getting all indicators

[jorgeacjitx]

Proposed changes

• The page size listing all indicators with the "getAll" param was hardcoded to 100. To increase performance, this restriction is proposed to be removed.

Related issues

• first parameter is not customizable when using the getAll option in list method #457

Checklist

• I consider the submitted work as finished
• I tested the code for its functionality
• I wrote test cases for the relevant uses case
• I added/update the relevant documentation (either on github or on notion)
• Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[yassine-ouaamou]

Hi @jorgeacjitx,
Thanks for your contribution. Can you fix the formatting of you code using "black"?

[jorgeacjitx]

Hi @jorgeacjitx, Thanks for your contribution. Can you fix the formatting of you code using "black"?

Yes, @yassine-ouaamou the problem is that the pre-commit hook is reformatting my code again. I just skipped the pre-commit hook and now the formatting looks good. Please look at the formatting pre-commit hook because it's not working fine.

[aHenryJard]

can you take "first" value when present and keep 100 as default when "fisrt" is not present ?

[jorgeacjitx]

Hi @aHenryJard,
The param "first" has a default value of 500:

client-python/pycti/entities/opencti_indicator.py

Line 58 in 58a624b

first = kwargs.get("first", 500)

When the "get_all" param is true, it is still used for querying (L121):

client-python/pycti/entities/opencti_indicator.py

Lines 109 to 121 in 58a624b

	if get_all:
	final_data = []
	data = self.opencti.process_multiple(result["data"]["indicators"])
	final_data = final_data + data
	while result["data"]["indicators"]["pageInfo"]["hasNextPage"]:
	after = result["data"]["indicators"]["pageInfo"]["endCursor"]
	self.opencti.app_logger.info("Listing Indicators", {"after": after})
	result = self.opencti.query(
	query,
	{
	"filters": filters,
	"search": search,
	"first": first,

[aHenryJard]

Tested locally all good for me, thank you.