V1.13.18 - Updates #274

ClutchplateDude · 2026-01-13T06:13:30Z

Merged oae-fw branch so that all mounts are in main branch (develop) now.
Added more output to the InfoDisplay during boot and fixed a bug in console mode.
Fixed a bug that was causing the firmware to hang after a slew, if a :Q# command was issued (thanks to user c3n for tracking it down, pun intended).

- OAE support - AZ/ALT debug output - Stop button now stop all motors (incl. AZ and ALT)

- Store AZ/ALT steps per degree and allow them to be set from Meade # Conflicts: # src/b_setup.hpp

- fix values and calculations for OAE ALT/AZ motion

… AZ and ALT steps storage and retrieval

- Added more output to the InfoDisplay during boot and fixed a bug in console mode. - Fixed a bug that was causing the firmware to hang after a slew, if a :Q# command was issued (thanks to user c3n for tracking it down, pun intended).

openastrotech-bot · 2026-01-13T06:13:45Z

Looks like your PR has code that needs to be changed in order to meet our coding standards!
Here are your options:

Apply the patch that was generated by the job
1. Click details under the failing clang-format check
2. Click the Artifacts dropdown in the top right
3. Download + unzip the clang-format-diff.patch file into the OpenAstroTracker-Firmware repo
4. Run git apply clang-format-diff.patch to make the changes
5. Commit and push up the formatted code
Run clang-format locally
1. Run the command bash -c 'shopt -s nullglob globstar;GLOBIGNORE=./src/libs/TimerInterrupt/*; for i in ./{.,src/**,unit_tests,boards/**}/*.{c,cpp,h,hpp}; do clang-format -i $i; done'
2. Commit and push up the formatted code

andre-stefanov · 2026-01-15T19:55:52Z

src/b_setup.hpp

 #if TEST_VERIFY_MODE == 1
    #ifdef OAM
    Serial.print(F("Booting OAM Firmware "));
+    #elif OAE


the first condition is #ifdef OAM which equals #if defined(OAM). the second one is "just" #elif OAE. This could cause issues if OAE flag is defined without a value.

Suggested change

#elif OAE

#elif defined(OAE)

Good catch!

andre-stefanov · 2026-01-15T19:59:18Z

src/b_setup.hpp

 #if USE_GPS == 1
+    LOG(DEBUG_ANY, "[SYSTEM]: Initializing GPS...");
+    #if (INFO_DISPLAY_TYPE != INFO_DISPLAY_TYPE_NONE)
+    int gpsLine = addConsoleText(F("Initialize GPS..."), false);


what is the argument false? addConsoleText(String text) in b_setup has just one parameter. InfoDisplayRender#addConsoleText on the other side has two parameters ... but second one does not seem to be used anywhere.

Damn, you are on a roll! Yeah, that was a leftover from when I replaced all the calls...

andre-stefanov · 2026-01-15T20:07:25Z

src/SSD1306_128x64_Display.hpp


    virtual int addConsoleText(String text, bool tinyFont)
    {
        _textList[_curLine++] = text;


i know it is not part of the PR, but we should check for overflow here. _curLine++ has to be smaller than MAX_CONSOLE_LINES

Otherwise we need a strategy ... maybe one of these:

FIFO like: adding a line would drop the first one. This is not that sexy to implement since we would need to shift all the array entries down before adding new line. It would be probably easier by using a ring buffer as structure.

drop new line and return an error

This is way out of date file.... urgh... let me check what's going on here.

andre-stefanov · 2026-01-15T20:15:44Z

ConfigurationValidation.hpp

            #error AZ driver address for DRIVER_TYPE_TMC2209_UART not specified.
        #endif
    #endif
+#elif defined(BOARD_OAE_V1)


This check will not work as expected. BOARD_OAE_V1 is always defined in Constants.hpp. Because of this the #else block will be never reached.

Suggested change

#elif defined(BOARD_OAE_V1)

#elif (BOARD == BOARD_OAE_V1)

andre-stefanov · 2026-01-15T20:15:49Z

ConfigurationValidation.hpp

        #endif
    #endif

+#elif defined(BOARD_OAE_V1)


This check will not work as expected. BOARD_OAE_V1 is always defined in Constants.hpp. Because of this the #else block will be never reached.

Suggested change

#elif defined(BOARD_OAE_V1)

#elif (BOARD == BOARD_OAE_V1)

andre-stefanov · 2026-01-15T20:22:22Z

src/SSD1306_128x64_Display.hpp

+#elif defined(OAE)
+            display->drawString(32, 6, F("OpenAstroExplorer"));


Duplicate of lines 98-99

Something is wrong in this PR, these are old files...

andre-stefanov · 2026-01-15T20:22:51Z

boards/ESP32_ESP32DEV/pins_OAE_V1.hpp

+/**
+ * @brief a pins configuration file for an ESP32-based OAT.
+ */
+
+#pragma once


duplicate of lines 1-5

boards/ESP32_ESP32DEV/pins_OAE_V1.hpp

intercipere and others added 18 commits June 3, 2025 09:09

add OAE config

a58fb49

RA DEC driver serial connection

2e58455

WIP Updates

e7f41da

- OAE support - AZ/ALT debug output - Stop button now stop all motors (incl. AZ and ALT)

Merge branch 'develop' into oae-fw

0c29076

WIP

e8ab597

V1.13.17 - Updates

4c9f938

- Store AZ/ALT steps per degree and allow them to be set from Meade # Conflicts: # src/b_setup.hpp

WIP

58a1f40

- fix values and calculations for OAE ALT/AZ motion

adjust TMC driver current

99ff3ad

Version bump

2bc86df

Version bump

c2a5f82

apply clang-format

3ebf8c7

Merged origin

cc68896

Enhance EEPROM handling by adding checks for disabled stepper axes in…

3f5c2b2

… AZ and ALT steps storage and retrieval

Merge branch 'develop' into oae-fw

f497455

Delete clang-format-diff.patch

f1184c3

Fix typo

790a953

Typo fixes

4705edd

V1.13.17 - Updates

842483e

- Added more output to the InfoDisplay during boot and fixed a bug in console mode. - Fixed a bug that was causing the firmware to hang after a slew, if a :Q# command was issued (thanks to user c3n for tracking it down, pun intended).

ClutchplateDude added 3 commits January 12, 2026 22:17

Lint fixes

b03820f

Logic fix, wrong indentation

bb9db73

More lint fixes

74f6ef1

ClutchplateDude changed the title ~~V1.13.17 - Updates~~ V1.13.18 - Updates Jan 13, 2026

Merge branch 'oae-fw' into slew-quit-hang

76c39e7

andre-stefanov self-requested a review January 15, 2026 19:32

andre-stefanov requested changes Jan 15, 2026

View reviewed changes

ClutchplateDude added 2 commits January 15, 2026 21:56

PR feedback addressed

5ecb69d

PR feedback

8dbe2a1

		#elif defined(OAE)
		display->drawString(32, 6, F("OpenAstroExplorer"));

V1.13.18 - Updates #274

Are you sure you want to change the base?

V1.13.18 - Updates #274

Uh oh!

Conversation

ClutchplateDude commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openastrotech-bot commented Jan 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ClutchplateDude commented Jan 13, 2026 •

edited

Loading