Repository navigation
fix(deps): hold vulnerable Maven transitives past their advisories in all three Java trees - #1602
Merged
Merged
Conversation
… all three Java trees osv-scanner 2.7.0 over each tree's CycloneDX aggregate SBOM (test scope excluded) reported 6 findings in client/java, 14 in editors/syson and 6 in editors/mdk, all in transitive dependencies: grpc-netty-shaded, bcprov/bcpkix and guava through the client's sigstore-java, jackson through the SysON Spring Boot BOM. Each parent pom now manages them in <dependencyManagement> (grpc-bom 1.85.1, bouncycastle 1.86, guava 33.7.2-jre, jackson-bom 3.1.8 in SysON); the scan reports no findings. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
#1593 (
feature/sca-gates) adds a failingmake audit-javastep — a CycloneDX aggregate SBOM per Maven tree (cyclonedx-maven-plugin:2.9.1:makeAggregateBom, test scope excluded) scanned by osv-scanner 2.7.0 — to the Java client, SysON plugin and MDK plugin CI jobs. #1589 moved the Go, npm and cargo pins; this is the Maven half, so #1593 can go green without weakening its gate.Measured on develop
1f4892cbc(before) and on this branch (after):client/javaeditors/sysoneditors/mdkEvery flagged artifact is transitive — none is a direct dependency of our code — so each tree's parent
pom.xmlholds it in<dependencyManagement>; no direct dependency was added and no generated stub changed (the client talks Connect over the JDKHttpClient; gRPC only arrives throughsigstore-java's release-signature verification, sogrpc-javahas no stubs to regenerate here).io.grpc:grpc-netty-shaded(and everyio.grpc:*, viagrpc-bomimport)sigstore-java→ client, syson, mdkorg.bouncycastle:bcprov-jdk18onsigstore-javaorg.bouncycastle:bcpkix-jdk18on(+bcutil-jdk18on, kept in step)sigstore-javacom.google.guava:guavasigstore-java/grpctools.jackson.core:jackson-core,jackson-databind(viajackson-bomimport, syson only)Versions are the current patch release of the same major in each case (gRPC 1.x, Bouncy Castle 1.x, Guava 33.x, Jackson 3.1.x), not the bare fixed-version floor. In
editors/sysonthe overrides are declared before the Spring Boot BOM import so Maven's first-declaration rule lets them win; the Spring Boot BOM managesjacksonat 3.1.4 andgrpcat 1.70.0 otherwise. The editors need their own management because a consumer's<dependencyManagement>is what decides a transitive's version — the client's pins would not carry over on their own.How it was verified
Measurement (the exact commands, from the repo root;
osv-scanner2.7.0 provisioned with #1593'sscripts/download-sca-tools.sh, SHA-256 verified):All three scans print
No issues found.CI job steps run locally, at the workflow's JDK majors, against a freshly built
bin/sysml-grpc(make build):java-test(JDK 17):mvn -B -f client/java/pom.xml install -Dopensysml.requireService=true— BUILD SUCCESS, 340 tests, 0 failures (1 skipped:ReleaseAssetsTest's pinned-release case, gated on an env var the job does not set — same as develop); conformance module 37 tests, 0 failures.mdk-plugin(JDK 17):mvn -B -f editors/mdk/pom.xml verify -Dopensysml.requireService=true— BUILD SUCCESS, 47 + 16 tests, 0 failures.syson-plugin(JDK 21):mvn -B -f editors/syson/pom.xml install -Dopensysml.requireService=true— BUILD SUCCESS, 73 tests, 0 failures.go build ./... && go vet ./... && gofmt -l .— clean (no Go touched).python3 scripts/changelog.py check— passes.Not run: the SysON frontend
npmsteps (untouched by this change) and the Cameo-side MDK packaging — themdk-pluginjob'smvn verifyis the whole Maven surface and needs no non-public artifact.Checklist
make testandmake lintpass locally — Go untouched:go build ./... && go vet ./... && gofmt -l .clean; Maven suites aboveaudit-javagate is the testdocs/project/releasing.mdhas no pin table listing these artifactschanges/unreleased/maven-dependency-vulnerabilities.security.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved — no gate count movedLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/f2db20fc999c44dd8d60457e741b1ca2
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/f2db20fc999c44dd8d60457e741b1ca2?variant=devin
Requested by: @HuiJun