Repository navigation
chore(deps): bump sigstore-java to 2.4.0 and hold its Apache HttpComponents past their advisories - #1672
Merged
Conversation
…onents past their advisories sigstore-java 2.4.0 brings google-http-client-apache-v5, whose httpclient5 5.3.1 and httpcore5/httpcore5-h2 5.2.x osv-scanner flags (GHSA-hjcp-jmpx-g3qm, GHSA-hf6x-8p5f-cgmf, GHSA-v3jc-474w-2wm6). The three Maven trees manage them at 5.6.5 / 5.4.4 beside the existing gRPC, Bouncy Castle and Guava pins, so make audit-java is clean again. Supersedes the Dependabot bump of the client pom. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Supersedes Dependabot's #1648, which bumps
dev.sigstore:sigstore-java1.3.0 → 2.4.0 inclient/javaand failsmake audit-java: the 2.x line adds agoogle-http-client-apache-v5transport that pullshttpclient55.3.1 andhttpcore5/httpcore5-h25.2.x, which osv-scanner reports against GHSA-hjcp-jmpx-g3qm, GHSA-hf6x-8p5f-cgmf and GHSA-v3jc-474w-2wm6 (theJava client testsandMagic MDK pluginjobs of its run both fail on exactly those three).This PR makes the same bump (
sigstore.version2.4.0 inclient/java/pom.xml) and holds the new transitives past their advisories the way #1602 holdsgrpc, Bouncy Castle and Guava: each tree's parentpom.xmlmanages them in<dependencyManagement>, no direct dependency added.org.apache.httpcomponents.client5:httpclient5sigstore-java→google-http-client-apache-v5org.apache.httpcomponents.core5:httpcore5org.apache.httpcomponents.core5:httpcore5-h2As in #1602 the versions are the current patch release of the same minor rather than the bare floor;
httpclient55.6.5 itself declareshttpcore55.4.4, so the two pins agree. The pins go in all three trees (client/java,editors/mdk,editors/syson) because a consumer's own management decides a transitive's version — the client's pins do not carry over, which is why #1648 also fails the MDK job. Ineditors/sysonthey sit before the Spring Boot BOM import, as the existing overrides do.sigstore-java 2.x's breaking changes (CHANGELOG) are on the signing side (
KeylessSigneralgorithm registry,SigningConfig, rekor v2 DSSE logging); the client only verifies, throughKeylessVerifier,VerificationOptions.CertificateMatcher,TrustedRootProvider,Bundle.fromandStringMatcher, all of which compile unchanged. The other transitives sigstore-java 2.4.0 brings (grpc1.85.1, Bouncy Castle 1.86, Guava 33.7.2-jre) already match the existing pins.How it was verified
The
java-test,mdk-pluginandsyson-pluginjob steps, run locally against the pinnedbin/sysml-grpc, osv-scanner 2.7.0 fromscripts/download-sca-tools.sh:make audit-java JAVA_PROJECT_DIRS=client/java—No issues found(40 packages);mvn -B -f client/java/pom.xml install -Dopensysml.requireService=true— BUILD SUCCESS, 342 tests, 0 failures, 1 skipped (the env-gated pinned-release case, as on develop), conformance module 37 tests, 0 failures.mvn -B -f editors/mdk/pom.xml verify -Dopensysml.requireService=true— BUILD SUCCESS, 48 + 16 tests, 0 failures;make audit-java JAVA_PROJECT_DIRS=editors/mdk—No issues found(47 packages).mvn -B -f editors/syson/pom.xml install -Dopensysml.requireService=true— BUILD SUCCESS, 73 tests, 0 failures;make audit-java JAVA_PROJECT_DIRS=editors/syson—No issues found(63 packages).python3 scripts/changelog.py checkpasses.Checklist
make testandmake lintpass locally — no Go touched; the three Maven suites aboveaudit-javagate is the testchanges/unreleased/sigstore-java-2.4.security.mdmake docs-countsrun if a gate count moved — none movedLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/11e2479f435a4bf7a432ec234313d8cd
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/11e2479f435a4bf7a432ec234313d8cd?variant=devin
Requested by: @HuiJun