Update Mend reader for XML and add Mend reader for SARIF #326
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| /** | ||
| * OWASP Benchmark Project | ||
| * | ||
| * <p>This file is part of the Open Web Application Security Project (OWASP) Benchmark Project For | ||
| * details, please see <a | ||
| * href="https://owasp.org/www-project-benchmark/">https://owasp.org/www-project-benchmark/</a>. | ||
| * | ||
| * <p>The OWASP Benchmark is free software: you can redistribute it and/or modify it under the terms | ||
| * of the GNU General Public License as published by the Free Software Foundation, version 2. | ||
| * | ||
| * <p>The OWASP Benchmark is distributed in the hope that it will be useful, but WITHOUT ANY | ||
| * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR | ||
| * PURPOSE. See the GNU General Public License for more details. | ||
| * | ||
| * @author Jan Kühl | ||
| * @created 2026 | ||
| */ | ||
| package org.owasp.benchmarkutils.score.parsers.sarif; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
| import org.json.JSONArray; | ||
| import org.json.JSONException; | ||
| import org.json.JSONObject; | ||
| import org.owasp.benchmarkutils.score.CweNumber; | ||
| import org.owasp.benchmarkutils.score.ResultFile; | ||
| import org.owasp.benchmarkutils.score.TestSuiteResults; | ||
|
|
||
| /** | ||
|
Contributor
There was a problem hiding this comment. Guess this is AI generated comment. It does not add any value, so I propose to remove it. |
||
| * This reader is made for Mend SAST reports using the SARIF format. Mend rules don't carry a CWE | ||
| * tag or field - the CWE is only present as the trailing number of each rule's {@code helpUri} | ||
| * (e.g. https://cwe.mitre.org/data/definitions/78.html), so CWEs are scraped from there | ||
| * automatically instead of providing a mapping of Mend rule id to CWE. | ||
| */ | ||
| public class MendSarifReader extends SarifReader { | ||
|
|
||
| public MendSarifReader() { | ||
| super("mend.sast.", true, CweSourceType.CUSTOM); | ||
| } | ||
|
|
||
| @Override | ||
| public String toolName(ResultFile resultFile) { | ||
| return "Mend SAST"; | ||
| } | ||
|
|
||
| /** | ||
| * Mend's SARIF driver reports its version as a descriptive, comma-separated string per language | ||
| * (e.g. {@code "26.6.1.2 (Java*)"}). | ||
| */ | ||
| @Override | ||
| public void setVersion(ResultFile resultFile, TestSuiteResults testSuiteResults) { | ||
| super.setVersion(resultFile, testSuiteResults); | ||
|
|
||
| String version = testSuiteResults.getToolVersion(); | ||
|
|
||
| if (version == null) { | ||
| return; | ||
| } | ||
|
|
||
| Matcher matcher = Pattern.compile("^[0-9][0-9.]*").matcher(version); | ||
|
|
||
| if (matcher.find()) { | ||
| testSuiteResults.setToolVersion(matcher.group()); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public Map<String, Integer> customRuleCweMappings(JSONObject tool) { | ||
| Map<String, Integer> ruleCweMap = new HashMap<>(); | ||
|
|
||
| JSONArray rules = tool.getJSONObject("driver").getJSONArray("rules"); | ||
|
|
||
| for (int i = 0; i < rules.length(); i++) { | ||
| try { | ||
| JSONObject rule = rules.getJSONObject(i); | ||
|
|
||
| ruleCweMap.put(rule.getString("id"), mapCwe(extractCwe(rule.getString("helpUri")))); | ||
| } catch (JSONException e) { | ||
| // Skip rules without a helpUri-based CWE reference. | ||
| } | ||
| } | ||
|
|
||
| return ruleCweMap; | ||
| } | ||
|
|
||
| @Override | ||
| public int mapCwe(int cwe) { | ||
| switch (cwe) { | ||
| case 338: | ||
| return CweNumber.WEAK_RANDOM; | ||
| case 1004: | ||
| return CweNumber.INSECURE_COOKIE; | ||
| default: | ||
| return cwe; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parseFindings and parseVulnerabilities looks very similar. Can you merge them somehow?