Update Mend reader for XML and add Mend reader for SARIF - #326
Open
jankuehl-ws wants to merge 2 commits into
Open
Update Mend reader for XML and add Mend reader for SARIF#326jankuehl-ws wants to merge 2 commits into
jankuehl-ws wants to merge 2 commits into
Conversation
Contributor
|
@darkspirit510 - Can you review and make sure there are test cases for the new features (and old). And if they are missing can you add them to this PR? Hopefully, they sent you some of the new format results files via email or something. |
hudara
approved these changes
Aug 16, 2026
darkspirit510
left a comment
darkspirit510
left a comment
Contributor
There was a problem hiding this comment.
Two minor remarks. Code itself looks good. Parsing works without errors.
| import org.owasp.benchmarkutils.score.ResultFile; | ||
| import org.owasp.benchmarkutils.score.TestSuiteResults; | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Guess this is AI generated comment. It does not add any value, so I propose to remove it.
| } | ||
| } | ||
|
|
||
| private void parseFindings(Report.EngineResults.Result result, TestSuiteResults tr) { |
Contributor
There was a problem hiding this comment.
parseFindings and parseVulnerabilities looks very similar. Can you merge them somehow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.