Repository navigation
CI: the Hackage publish builds the docs before it uploads the package - #90
Merged
Merged
Conversation
The package was uploaded before the documentation was built, so a documentation build that failed left a version on Hackage with no docs, and a version cannot be withdrawn. Both are now built first, and the two uploads run back to back. Comments that narrated past releases now say what each step does and why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish.ymluploaded the sdist, then built the documentation, then uploaded it. A documentation build that failed left the version on Hackage with no documentation, and a Hackage version cannot be withdrawn; the upload step's duplicate-version skip exists so a re-run can still reach the docs.The documentation is now built right after the sdist, before either upload, so everything that can fail runs before anything is published, and the two uploads run back to back. The duplicate-version skip stays, for a re-run after a failed documentation upload. Hackage cannot publish a package and its documentation together: publishing a candidate copies only its tarball and
.cabalfile (publishCandidatein hackage-server'sPackageCandidates.hs).Comments that narrated past releases (0.9.0.0's undated changelog and missing docs, the builder's GHC version at one point in time, an issue number) now say what each step does and why. The
haskell/cabal#9577undo condition for the sublibrary graft stays.Checks: actionlint clean; ASCII only; the steps' commands are unchanged, only their order and comments.