Skip to content

Bots can attack toward an optional coordinate #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunzenshen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bots can attack toward an optional coordinate #2000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cade4c
Bots can attack toward an optional coordinate
sunzenshen Jun 22, 2026
b939e44
Remove Attack transitions that don't have line of sight to threat
sunzenshen Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
406 changes: 275 additions & 131 deletions src/game/server/neo/bot/behavior/neo_bot_attack.cpp
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 4 additions & 3 deletions src/game/server/neo/bot/behavior/neo_bot_attack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ class CNEOBotAttack : public Action< CNEOBot >
{
public:
CNEOBotAttack( void );
CNEOBotAttack( const Vector &goalPosition );
virtual ~CNEOBotAttack() { }

virtual ActionResult< CNEOBot > OnStart( CNEOBot *me, Action< CNEOBot > *priorAction );
Expand All @@ -26,10 +27,10 @@ class CNEOBotAttack : public Action< CNEOBot >
virtual const char *GetName( void ) const { return "Attack"; };

private:
bool m_bSawEnemySinceLastPathCompute; // throttles m_attackCoverArea search
const CNavArea *m_attackCoverArea; // attempting to advance towards this cover area
const CNavArea *m_goalArea; // if set, engage enemies while moving towards this destination
PathFollower m_path;
ChasePath m_chasePath;
CountdownTimer m_attackCoverTimer;
CountdownTimer m_grenadeThrowCooldownTimer;
CountdownTimer m_repathTimer;
CNavArea *m_attackCoverArea;
};
13 changes: 13 additions & 0 deletions src/game/server/neo/bot/behavior/neo_bot_command_follow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,19 @@ ActionResult< CNEOBot > CNEOBotCommandFollow::Update(CNEOBot *me, float interval
return Done("Lost commander or released");
}

if (const CKnownEntity *threat = me->GetVisionInterface()->GetPrimaryKnownThreat(true) )
{
if ( CNEO_Player *pCommander = me->m_hCommandingPlayer.Get() )
{
const Vector& vWaypointPingLocation = pCommander->m_vLastPingByStar.Get(me->GetStar());
return SuspendFor( new CNEOBotAttack(vWaypointPingLocation), "Engaging enemy en route to waypoint" );

@sunzenshen sunzenshen Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding an optional vector position parameter to CNEOBotAttack, we can direct bots to search for cover in the direction of the vector position. For example, in this case we are directing the bots to attack the enemy while advancing between cover spots that are directionally closer to their commanding player's ping waypoint.

One known design tradeoff is that bots will not immediate change their direction of movement if the player places another ping when the bots are in the Attack behavior. My thinking is that this is okay, as bots should terminate the attack behavior earlier when they both have the optional goal waypoint while not seeing the enemy when moving between cover. I think it's fine not to interrupt the bots in the middle of their current plan, as it's more important that they don't change their minds indecisively and get destroyed when executing a cover plan.

}
else
{
return SuspendFor( new CNEOBotAttack, "Breaking formation to engage enemy" );
}
}

ActionResult<CNEOBot> weaponRequestResult = CheckCommanderWeaponRequest(me);
if (weaponRequestResult.IsRequestingChange())
{
Expand Down
15 changes: 4 additions & 11 deletions src/game/server/neo/bot/behavior/neo_bot_ctg_enemy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ CNEOBotCtgEnemy::CNEOBotCtgEnemy( void )
//---------------------------------------------------------------------------------------------
ActionResult< CNEOBot > CNEOBotCtgEnemy::OnStart( CNEOBot *me, Action< CNEOBot > *priorAction )
{
m_path.SetMinLookAheadDistance( me->GetDesiredPathLookAheadRange() );
m_repathTimer.Invalidate();
m_chasePath.SetMinLookAheadDistance( me->GetDesiredPathLookAheadRange() );

return Continue();
}
Expand All @@ -40,20 +39,14 @@ ActionResult< CNEOBot > CNEOBotCtgEnemy::Update( CNEOBot *me, float interval )
return Done( "Ghost carrier is friendly" );
}

const CKnownEntity *threat = me->GetVisionInterface()->GetPrimaryKnownThreat();
const CKnownEntity *threat = me->GetVisionInterface()->GetPrimaryKnownThreat(true);
if ( threat && !threat->IsObsolete() && me->GetIntentionInterface()->ShouldAttack( me, threat ) )
{
return SuspendFor( new CNEOBotAttack, "Attacking ghoster team" );
return SuspendFor( new CNEOBotAttack(pGhostCarrier->GetAbsOrigin()), "Attacking ghoster team" );
}

// Investigate the ghost carrier's position
if ( m_repathTimer.IsElapsed() )
{
// FASTEST_ROUTE: don't waste chase time looking for cover
CNEOBotPathCompute( me, m_path, pGhostCarrier->GetAbsOrigin(), FASTEST_ROUTE );
m_repathTimer.Start( RandomFloat( 0.2f, 1.0f ) );
}
m_path.Update( me );
CNEOBotPathUpdateChase( me, m_chasePath, pGhostCarrier, DEFAULT_ROUTE );

return Continue();
}
Expand Down
3 changes: 1 addition & 2 deletions src/game/server/neo/bot/behavior/neo_bot_ctg_enemy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ class CNEOBotCtgEnemy : public Action< CNEOBot >
virtual const char *GetName( void ) const override { return "ctgEnemy"; }

private:
PathFollower m_path;
CountdownTimer m_repathTimer;
ChasePath m_chasePath;
};

#endif // NEO_BOT_CTG_ENEMY_H
47 changes: 15 additions & 32 deletions src/game/server/neo/bot/behavior/neo_bot_ctg_escort.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,6 @@ ActionResult< CNEOBot > CNEOBotCtgEscort::Update( CNEOBot *me, float interval )
{
return Done( "Ghost carrier is not a teammate anymore" );
}

// Check if we can assist the Ghost Carrier (if they are a bot)
CNEOBot *pBotGhostCarrier = ToNEOBot( pGhostCarrier );
if ( pBotGhostCarrier )
{
const CKnownEntity *carrierThreat = pBotGhostCarrier->GetVisionInterface()->GetPrimaryKnownThreat();
if ( carrierThreat )
{
// Check if the threat has a clear shot at our friend
if ( me->IsLineOfFireClear( carrierThreat->GetLastKnownPosition(), pGhostCarrier, CNEOBot::LINE_OF_FIRE_FLAGS_DEFAULT ) )
{
return SuspendFor( new CNEOBotAttack, "Assisting Ghost Carrier with their threat" );
}
}
}

if ( m_repathTimer.IsElapsed() )
{
Expand All @@ -83,17 +68,25 @@ ActionResult< CNEOBot > CNEOBotCtgEscort::Update( CNEOBot *me, float interval )
}
}

if ( const CKnownEntity *threat = me->GetVisionInterface()->GetPrimaryKnownThreat(true) )
{
const Vector& ghosterPos = pGhostCarrier->GetAbsOrigin();
const Vector& threatPos = threat->GetLastKnownPosition();
if ( me->GetAbsOrigin().DistToSqr( threatPos ) > ghosterPos.DistToSqr( threatPos ) )
{
return SuspendFor( new CNEOBotAttack( ghosterPos ), "Engaging threats while regrouping with ghoster" );
}
else
{
return SuspendFor( new CNEOBotAttack(), "Intercepting threat while protecting ghoster" );
}
}

bool bCanSeeCarrier = me->GetVisionInterface()->IsLineOfSightClear( pGhostCarrier->WorldSpaceCenter() );
if ( bCanSeeCarrier )
{
m_lostSightOfCarrierTimer.Invalidate();

const CKnownEntity *threat = me->GetVisionInterface()->GetPrimaryKnownThreat(true);
if ( threat && threat->GetEntity() && threat->GetEntity()->IsAlive() )
{
return SuspendFor( new CNEOBotAttack, "Breaking away from ghoster to engage threat" );
}

if ( !m_bHasGoal )
{
// Asymmetric defense: No goal cap zone, so defend the carrier.
Expand Down Expand Up @@ -158,17 +151,6 @@ ActionResult< CNEOBot > CNEOBotCtgEscort::Update( CNEOBot *me, float interval )

if ( !m_bHasGoal )
{
// Asymmetric defense: No goal cap zone, so defend the carrier.
if ( pBotGhostCarrier )
{
const CKnownEntity *carrierThreat = pBotGhostCarrier->GetVisionInterface()->GetPrimaryKnownThreat();
if ( carrierThreat && carrierThreat->GetEntity() && carrierThreat->GetEntity()->IsAlive() )
{
me->GetVisionInterface()->AddKnownEntity( carrierThreat->GetEntity() );
return SuspendFor( new CNEOBotAttack, "Attacking enemy during asymmetric defense" );

@sunzenshen sunzenshen Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Attack transition was actually fine since there's no movement goal, but ironically removing this proactive attack behavior both simplifies this behavior, and is actually the more effective tactic against another bot team on the map isolation.

}
}

// No active threats to carrier
float flDistToCarrierSq = me->GetAbsOrigin().DistToSqr( pGhostCarrier->GetAbsOrigin() );
if ( flDistToCarrierSq > flSafeRadiusSq )
Expand All @@ -190,6 +172,7 @@ ActionResult< CNEOBot > CNEOBotCtgEscort::Update( CNEOBot *me, float interval )
Vector& vecMoveTarget = m_vecGoalPos;


CNEOBot *pBotGhostCarrier = ToNEOBot( pGhostCarrier );
if ( m_role == ROLE_SCREEN && pBotGhostCarrier )
{
CWeaponGhost *pGhost = dynamic_cast<CWeaponGhost*>( pBotGhostCarrier->Weapon_GetSlot( 0 ) );
Expand Down
29 changes: 11 additions & 18 deletions src/game/server/neo/bot/behavior/neo_bot_jgr_capture.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,27 +109,20 @@ ActionResult<CNEOBot> CNEOBotJgrCapture::Update( CNEOBot *me, float interval )
}
}

CBasePlayer *pActivatingPlayer = m_hObjective->GetActivatingPlayer();
if ( pActivatingPlayer )
if ( me->GetVisionInterface()->GetPrimaryKnownThreat() )
{
if ( !me->InSameTeam( pActivatingPlayer ) )
{
return SuspendFor( new CNEOBotAttack, "Attacking enemy capturing the juggernaut" );
}
else if ( pActivatingPlayer != me )
{
if ( me->GetVisionInterface()->GetPrimaryKnownThreat() )
{
return SuspendFor( new CNEOBotAttack, "Defending teammate capturing the juggernaut" );
}
return SuspendFor( new CNEOBotAttack, "Engaging enemy near juggernaut capture zone" );
}

// Look away from the juggernaut to watch for threats
CNEOBotJgrCapture::LookAwayFrom( me, m_hObjective );
CBasePlayer *pActivatingPlayer = m_hObjective->GetActivatingPlayer();
if ( pActivatingPlayer && me->InSameTeam( pActivatingPlayer ) && ( pActivatingPlayer != me ) )
{
// Look away from the juggernaut to watch for threats
CNEOBotJgrCapture::LookAwayFrom( me, m_hObjective );

me->ReleaseUseButton();
m_useAttemptTimer.Invalidate();
return Continue();
}
me->ReleaseUseButton();
m_useAttemptTimer.Invalidate();
return Continue();
}

if ( me->GetAbsOrigin().DistToSqr( m_hObjective->GetAbsOrigin() ) < CNEO_Juggernaut::GetUseDistanceSquared() )
Expand Down
4 changes: 2 additions & 2 deletions src/game/server/neo/bot/behavior/neo_bot_jgr_enemy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ ActionResult< CNEOBot > CNEOBotJgrEnemy::Update( CNEOBot *me, float interval )
return Done( "Juggernaut is friendly" );
}

const CKnownEntity *threat = me->GetVisionInterface()->GetPrimaryKnownThreat();
const CKnownEntity *threat = me->GetVisionInterface()->GetPrimaryKnownThreat(true);
if ( threat && !threat->IsObsolete() && me->GetIntentionInterface()->ShouldAttack( me, threat ) )
{
return SuspendFor( new CNEOBotAttack, "Attacking threat" );
return SuspendFor( new CNEOBotAttack( pJuggernaut->GetAbsOrigin() ), "Attacking threat en route to juggernaut" );
}

// Chase the Juggernaut
Expand Down
19 changes: 2 additions & 17 deletions src/game/server/neo/bot/behavior/neo_bot_jgr_escort.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,26 +47,11 @@ ActionResult< CNEOBot > CNEOBotJgrEscort::Update( CNEOBot *me, float interval )
return Done( "Juggernaut is not friendly" );
}

// Check if we can assist the Juggernaut (if they are a bot)
CNEOBot *pBotJuggernaut = ToNEOBot( pJuggernaut );
if ( pBotJuggernaut )
{
const CKnownEntity *juggernautThreat = pBotJuggernaut->GetVisionInterface()->GetPrimaryKnownThreat();
if ( juggernautThreat )
{
// Check if the threat has a clear shot at our friend
if ( me->IsLineOfFireClear( juggernautThreat->GetLastKnownPosition(), pJuggernaut, CNEOBot::LINE_OF_FIRE_FLAGS_DEFAULT ) )
{
return SuspendFor( new CNEOBotAttack, "Assisting Juggernaut with their threat" );
}
}
}

// Check for own threats
const CKnownEntity *myThreat = me->GetVisionInterface()->GetPrimaryKnownThreat();
const CKnownEntity *myThreat = me->GetVisionInterface()->GetPrimaryKnownThreat(true);
if ( myThreat && myThreat->GetEntity() && myThreat->GetEntity()->IsAlive() )
{
return SuspendFor( new CNEOBotAttack, "Breaking away from Juggernaut to engage threat" );
return SuspendFor( new CNEOBotAttack( pJuggernaut->GetAbsOrigin() ), "Engaging enemy to lure them to Juggernaut" );
}

// Just follow the Juggernaut
Expand Down
9 changes: 5 additions & 4 deletions src/game/server/neo/bot/behavior/neo_bot_jgr_seek.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ ActionResult< CNEOBot > CNEOBotJgrSeek::Update( CNEOBot *me, float interval )
// Juggernaut objective capture logic
if (m_bGoingToTargetEntity && m_hTargetEntity)
{
if ( me->GetVisionInterface()->GetPrimaryKnownThreat(true) )
{
return SuspendFor( new CNEOBotAttack( m_hTargetEntity->GetAbsOrigin() ), "Engaging enemies en route to juggernaut" );
}

const float useRangeSq = CNEO_Juggernaut::GetUseDistanceSquared() * 0.8f;
if ( me->GetAbsOrigin().DistToSqr( m_hTargetEntity->GetAbsOrigin() ) < useRangeSq )
{
Expand All @@ -75,10 +80,6 @@ ActionResult< CNEOBot > CNEOBotJgrSeek::Update( CNEOBot *me, float interval )
{
CNEOBotJgrCapture::LookAwayFrom( me, pJgr );
m_path.Invalidate(); // wait at juggernaut
if ( me->GetVisionInterface()->GetPrimaryKnownThreat() )
{
return SuspendFor( new CNEOBotAttack, "Intercepting enemies near juggernaut" );
}
return Continue();
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/game/server/neo/bot/behavior/neo_bot_retreat_from_grenade.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class CSearchForCoverFromGrenade : public ISearchSurroundingAreasFunctor
const CNavArea *grenadeArea = TheNavMesh->GetNavArea( m_grenade->GetAbsOrigin() );
if ( grenadeArea )
{
if ( area->IsPotentiallyVisible( grenadeArea ) )
if ( grenadeArea->IsPotentiallyVisible( area ) )

@sunzenshen sunzenshen Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this PR I took some time to review whether the directionality of observation made sense for every call for IsPotentiallyVisible and IsCompletelyVisible.

{
// area is exposed to grenade line of sight
return true;
Expand Down Expand Up @@ -212,14 +212,14 @@ ActionResult< CNEOBot > CNEOBotRetreatFromGrenade::Update( CNEOBot *me, float in
bool bIsExposed = false;
if ( grenadeArea && me->GetLastKnownArea() )
{
if ( me->GetLastKnownArea()->IsPotentiallyVisible( grenadeArea ) )
if ( grenadeArea->IsPotentiallyVisible( me->GetLastKnownArea() ) )
{
bIsExposed = true;
}
}

// track projectile and relation to escape destination every update
if ( !m_coverArea || ( grenadeArea && m_coverArea->IsPotentiallyVisible( grenadeArea ) ) )
if ( !m_coverArea || ( grenadeArea && grenadeArea->IsPotentiallyVisible( m_coverArea ) ) )
{
m_coverArea = FindCoverArea( me );
}
Expand Down
2 changes: 1 addition & 1 deletion src/game/server/neo/bot/behavior/neo_bot_retreat_to_cover.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class CTestAreaAgainstThreats : public IVision::IForEachKnownEntity
return true; // Can't test area if we don't know last area of threat
}

if ( !m_area->IsPotentiallyVisible( threatArea ) )
if ( !threatArea->IsPotentiallyVisible( m_area ) )
{
return true; // Candidate area is not visible by threat
}
Expand Down
52 changes: 48 additions & 4 deletions src/game/server/neo/bot/behavior/neo_bot_seek_and_destroy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ ActionResult< CNEOBot > CNEOBotSeekAndDestroy::UpdateCommon( CNEOBot *me, float
return Done( "Disabled." );
}

const CKnownEntity *threat = me->GetVisionInterface()->GetPrimaryKnownThreat();
const CKnownEntity *threat = me->GetVisionInterface()->GetPrimaryKnownThreat(true);

if ( threat )
{
Expand All @@ -193,11 +193,55 @@ ActionResult< CNEOBot > CNEOBotSeekAndDestroy::UpdateCommon( CNEOBot *me, float
const bool bDontSuspendForGhoster = (neoThreat && neoThreat->IsCarryingGhost());
if (!bDontSuspendForGhoster)
{
const float engageRange = 1000.0f;
if ( me->IsRangeLessThan( threat->GetLastKnownPosition(), engageRange ) )
const Vector& threatLastKnownPos = threat->GetLastKnownPosition();
// fall back to nearest teammate for backup if I am the closest contact to enemy
if ( NEORules()->IsTeamplay() )
{
return SuspendFor( new CNEOBotAttack, "Going after an enemy" );
bool bAnyTeammatesCloserToEnemy = false;
CNEO_Player* pNearestTeammate = nullptr;
float distToNearestTeammateSqr = FLT_MAX;
const Vector& myPos = me->GetAbsOrigin();
const float distMeToThreatSqr = myPos.DistToSqr(threatLastKnownPos);

for (int i = 1; i <= gpGlobals->maxClients; i++)
{
CBasePlayer *pPlayer = UTIL_PlayerByIndex(i);
if (!pPlayer)
{
continue;
}

CNEO_Player *pNeoCandidate = ToNEOPlayer(pPlayer);
if (!pNeoCandidate)
{
continue;
}

if (pNeoCandidate->InSameTeam(me) && (me != pNeoCandidate))
{
const Vector& candidatePos = pNeoCandidate->GetAbsOrigin();
if (threatLastKnownPos.DistToSqr(candidatePos) < distMeToThreatSqr)
{
bAnyTeammatesCloserToEnemy = true;
break;
}

float distCandidateSqr = myPos.DistToSqr(candidatePos);
if (distCandidateSqr < distToNearestTeammateSqr)
{
distToNearestTeammateSqr = distCandidateSqr;
pNearestTeammate = pNeoCandidate;
}
}
}

if (!bAnyTeammatesCloserToEnemy && pNearestTeammate)
{
return SuspendFor( new CNEOBotAttack( pNearestTeammate->GetAbsOrigin() ), "Kiting enemy toward teammate for backup" );
}
}

return SuspendFor( new CNEOBotAttack, "Going after an enemy" );
}
}
else
Expand Down
Loading