Skip to content

Comments

NeoUI - Fix first-used force active textedit not properly set cursor#1715

Merged
nullsystem merged 1 commit intoNeotokyoRebuild:masterfrom
nullsystem:FixForceInputFirstTextEdit
Feb 22, 2026
Merged

NeoUI - Fix first-used force active textedit not properly set cursor#1715
nullsystem merged 1 commit intoNeotokyoRebuild:masterfrom
nullsystem:FixForceInputFirstTextEdit

Conversation

@nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Feb 21, 2026

Description

Password input textedit have forced active and if that textedit is used first, the cursor are not set properly and when the player enters a character the cursor goes left of the character, not right. Just add an if-statement to check if selection variables set to -1 and widget is active, set it to the size of the current text.

Test it with local server, make sure no other text edits are touched, create a local server then go to server list, enter that local server, see that password section, and start typing. The cursor should stay on the most-right side/end of the password text input.

Toolchain

  • Linux GCC Distro Native GCC 15

@nullsystem nullsystem requested a review from a team February 21, 2026 20:38
sunzenshen
sunzenshen previously approved these changes Feb 21, 2026
Copy link
Contributor

@sunzenshen sunzenshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, not sure how to test if there are no servers up for this branch version, but looks sensible enough to me.

@sunzenshen sunzenshen requested a review from a team February 21, 2026 20:52
@nullsystem
Copy link
Collaborator Author

To be honest, not sure how to test if there are no servers up for this branch version, but looks sensible enough to me.

@sunzenshen I've tested it using a local server, which is password protected by default so don't need to touch other text inputs before using password input.

Password input textedit have forced active and if that textedit is
used first, the cursor are not set properly and when the player
enters a character the cursor goes left of the character, not right.
Just add an if-statement to check if selection variables set to -1
and widget is active, set it to the size of the current text.
Also reset it to -1 on changing context.
@nullsystem nullsystem force-pushed the FixForceInputFirstTextEdit branch from e1559f8 to 3eeffab Compare February 21, 2026 21:00
@nullsystem nullsystem added the Tournament Priority Issues to be prioritized for the upcoming NT;RE tournament label Feb 21, 2026
@sunzenshen sunzenshen requested a review from a team February 21, 2026 21:21
@DESTROYGIRL DESTROYGIRL added the UI/HUD Relates to the HUD, NeoUI, menus, etc label Feb 22, 2026
@nullsystem nullsystem merged commit 483940a into NeotokyoRebuild:master Feb 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tournament Priority Issues to be prioritized for the upcoming NT;RE tournament UI/HUD Relates to the HUD, NeoUI, menus, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants