NeoUI - Color widgets and Begin/EndPopup#1706
Merged
nullsystem merged 3 commits intoNeotokyoRebuild:masterfrom Feb 21, 2026
Merged
NeoUI - Color widgets and Begin/EndPopup#1706nullsystem merged 3 commits intoNeotokyoRebuild:masterfrom
nullsystem merged 3 commits intoNeotokyoRebuild:masterfrom
Conversation
nullsystem
force-pushed
the
GH-1484_NeoUIColorWidget
branch
from
84a67e5 to
794a6f0
Compare
Color widgets shows the color from given RGBA values and acts as a button to show a popup where the RGBA values can be altered. This also changed how popups are handled, they are now similar to sections and can hold the same widgets and layouts as sections but have specialized handling for popup functionalities. Keyboard and controller can exit popup with ESC/back-related bind, and showing popup on first initialization activates on the first item of the popup, although this is an optional behavior only utilized for color widgets. Copy, server, and blacklist menus all migrated to using the new Begin/EndPopup. * fixes NeotokyoRebuild#1484
nullsystem
force-pushed
the
GH-1484_NeoUIColorWidget
branch
from
794a6f0 to
005926c
Compare
Rainyan
previously approved these changes
Feb 21, 2026
Collaborator
Rainyan
left a comment
Rainyan
left a comment
There was a problem hiding this comment.
LGTM
As a nit, it would be nice to be able to move to next/previous field within a popup using tab and shift+tab, similar to how the up/down arrow keys work. For example, after typing a color Red value, it would be nice to be able to press tab to move the cursor to the Green value and so on.
Allow up/down to also be done with tab key, although restricted for popups only. TODO in the future might actually change current non-popup tab behavior from switching sections to also up/down and up/down goes through all sections not just one, but this is out of scope of this pull request.
Collaborator
Author
Rainyan
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Color widgets shows the color from given RGBA values and acts as a button to show a popup where the RGBA values can be altered. This also changed how popups are handled, they are now similar to sections and can hold the same widgets and layouts as sections but have specialized handling for popup functionalities.
Keyboard and controller can exit popup with ESC/back-related bind, and showing popup on first initialization activates on the first item of the popup, although this is an optional behavior only utilized for color widgets.
Copy, server, and blacklist menus all migrated to using the new Begin/EndPopup.
Toolchain
Linked Issues