Skip to content

Ask for compiler baselines in custom GPU kernel reviews #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akihironitta merged 1 commit into from
Oct 23, 2026
Merged

Ask for compiler baselines in custom GPU kernel reviews #1255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .coderabbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ reviews:
dependencies optional). In `__init__.py`, imports and `__all__`
are intentionally ordered by dependency, not alphabetically — do
not suggest alphabetical sorting there.
- path: 'sdm/_kernels/**'
instructions: >-
For changes introducing or expanding a custom GPU kernel, check
whether the performance evidence includes a practical
compiler-generated or existing-library alternative. If absent,
request a comparison or a concrete explanation of incompatibility.
Check that comparisons preserve workload and numerical requirements
and distinguish startup from prediction latency. Treat this as a
justification question; do not infer performance from source code
alone.
- path: 'test/**/*.py'
instructions: >-
Pytest-based tests. Check that behavior changes in sdm/ have
Expand Down
Loading