Skip to content

Add cross_channel=False warning in case covariates exist #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusty1s merged 6 commits into from
Oct 16, 2026
Merged

Add cross_channel=False warning in case covariates exist #1165

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
21ffc11
update
rusty1s Oct 16, 2026
f5ed2c1
update
rusty1s Oct 16, 2026
2edbb96
update
rusty1s Oct 16, 2026
315a035
update
rusty1s Oct 16, 2026
cb8f383
Merge branch 'main' into add_usage_warn
rusty1s Oct 16, 2026
d5bd45b
update
rusty1s Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sdm/models/kumo/timeseries/forecast/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,15 @@ def _forward(
assert y_context is not None
y_schema = y_context.schema
x = y_context.numerical
if x_context_only is not None:
if x_context_only is not None and x_context_only.size(-1) > 0:
if self.model.cross_channel is None:
warn_once(
key="kumo-forecast-historical-covariate",
message=(
"Historical covariates have no effect when "
"'cross_channel' is disabled."
),
)
x = torch.cat([x, x_context_only.numerical], dim=-1)

x = x[..., -self.model.context_size :, :].transpose(-1, -2)
Expand Down
Loading