Skip to content

Add cross_channel=False warning in case covariates exist - #1165

Merged
rusty1s merged 6 commits into
mainfrom
add_usage_warn
Oct 16, 2026
Merged

rusty1s merged 6 commits into
mainfrom
add_usage_warn

Conversation

@rusty1s

@rusty1s rusty1s commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@copy-pr-bot

copy-pr-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/structured-data-models/.coderabbit.yaml
  • Review profile: QUIET
  • Plan: Enterprise
  • Run ID: 979558cb-e145-4170-b894-97836b02e582
📥 Commits

Reviewing files that changed from the base of the PR and between 5afe9ec and cb8f383.

📒 Files selected for processing: 1
  • sdm/models/kumo/timeseries/forecast/model.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Behavior
    • A one-time warning now appears when historical context-only columns are provided while cross-channel forecasting is disabled. Forecasting continues with those columns included.

KumoForecast._forward now warns once when historical context-only columns are present and cross_channel is disabled. It continues to concatenate those columns with target history.

Changes: Forecast context warning

Layer / File(s) Summary
Forward-path warning
sdm/models/kumo/timeseries/forecast/model.py
_forward warns once when context-only historical columns are nonempty and cross_channel is None. The existing concatenation with target history remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to cb8f3

With cross-channel attention disabled, context-only columns do not affect target forecasts; the warning explains this limitation. No actionable merge risk was identified.

Pre-merge checks: Passed 3 · Failed 1 · Inconclusive 1

Failed Failed checks: 1 warning · 1 inconclusive

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check Inconclusive No pull request description was provided, so the change intent and validation details are not documented beyond the title. Add a brief description that explains the warning behavior, the affected condition, and the expected handling of historical context-only columns.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly describes the main change: adding a warning when covariates exist while cross_channel is disabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@rusty1s
rusty1s merged commit 728b859 into main Oct 16, 2026
4 of 5 checks passed
@rusty1s
rusty1s deleted the add_usage_warn branch October 16, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant