[WIP] : add ability to dynamically detect gdrcopy module #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
Comment on lines
+36
to
+37
| // isDriverLoaded checks if the specified driver module is loaded by reading the modules file. | ||
| // It first checks "/host/proc/modules" (for containerized environments) and falls back to "/proc/modules" if not found. |
Collaborator
There was a problem hiding this comment.
Nit: let's keep a maximum column length for the docu-comments around 80.
| }) | ||
| } | ||
|
|
||
| // isDriverLoadedWithPath checks if the specified driver module is loaded by reading the specified modules file. |
Collaborator
There was a problem hiding this comment.
Nit: let's keep a maximum column length for the docu-comments around 80.
elezar
reviewed
Dec 9, 2025
| cdi.WithDeviceIDStrategy(*config.Flags.Plugin.DeviceIDStrategy), | ||
| cdi.WithVendor("k8s.device-plugin.nvidia.com"), | ||
| cdi.WithGdrcopyEnabled(*config.Flags.GDRCopyEnabled), | ||
| cdi.WithGdrcopyEnabled(*config.Flags.GDRCopyEnabled || utils.IsGdrdrvLoaded()), |
Member
There was a problem hiding this comment.
Question: Since these are effectively no-ops if the drivers are not available, is it a simpler change to change the default for these settings instead of adding logic to check whether the modules are loaded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.