Skip to content

Conversation

@Andy-Jost
Copy link
Contributor

Summary

  • Clarify why build and test jobs are split by platform (to allow independent dependencies)
  • Document the allowed textual differences between job definitions
  • Unify if: conditions across test jobs for consistency

Changes

This is a documentation/comment-only change to ci.yml. No functional changes to the CI behavior.

Build jobs:

  • Replaced vague "WARNING: keep in sync" with explanation of why jobs are split
  • Documented allowed differences: host-platform value and if: condition

Test jobs:

  • Same pattern: primary explanation at test-linux-64, references at others
  • Made if: conditions uniform (added doc-only check to all test jobs)
  • Added should-skip to needs: where required

Clarify why build and test jobs are split by platform rather than using
a matrix: to allow independent dependencies so faster platforms can
proceed through build & test without waiting for slower ones. Document
the allowed textual differences between job definitions.

Also unify the if: conditions across test jobs for consistency.
@Andy-Jost Andy-Jost added the documentation Improvements or additions to documentation label Jan 15, 2026
@Andy-Jost Andy-Jost self-assigned this Jan 15, 2026
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 15, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Andy-Jost
Copy link
Contributor Author

/ok to test b404012

@Andy-Jost Andy-Jost requested review from cpcloud and leofang January 15, 2026 20:09
@github-actions

This comment has been minimized.

@Andy-Jost Andy-Jost enabled auto-merge (squash) January 15, 2026 20:57
@Andy-Jost
Copy link
Contributor Author

pre-commit.ci run

@Andy-Jost Andy-Jost merged commit 0b1b3fd into NVIDIA:main Jan 15, 2026
20 checks passed
@Andy-Jost Andy-Jost deleted the improve-ci-comments branch January 15, 2026 22:05
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants