Skip to content

Task/NPA-6616/replace regulatory basis with policy rule #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hatwell merged 13 commits into from
Apr 16, 2026
Merged

Task/NPA-6616/replace regulatory basis with policy rule #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
71d4eca
NPA-6521: refactor function to reduce complexity and also have a chan…
hatwell Apr 13, 2026
e38a29c
NPA-6521: kill flask process fully
hatwell Apr 13, 2026
6adfaf5
NPA-6521: revert dummy change
hatwell Apr 13, 2026
79e982a
NPA-6637: update examples
hatwell Apr 14, 2026
3d071a8
NPA-6637: update single relationship examples with parental responsbi…
hatwell Apr 14, 2026
8cd1fdb
NPA-6637: update examples for multiple relationsiphs
hatwell Apr 14, 2026
5e5424e
NPA-6521: update other examples
hatwell Apr 14, 2026
fd07185
NPA-6637: update int postman collection
hatwell Apr 14, 2026
176f646
NPA-6637: update spec with deprecated property for now
hatwell Apr 14, 2026
e25ca4b
Merge branch 'master' into task/NPA-6637/replace-regulatory-basis-wit…
hatwell Apr 14, 2026
84020ad
NPA-6637: remove references to regulatory basis from spec
hatwell Apr 15, 2026
6483ea8
NPA-6637: update example name
hatwell Apr 15, 2026
c36e3a7
NPA-6618: update postman collection
hatwell Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 45 additions & 45 deletions postman/validated_relationship_service.integration.postman_collection.json
View file
Open in desktop

Large diffs are not rendered by default.

58 changes: 29 additions & 29 deletions postman/validated_relationship_service.sandbox.postman_collection.json
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 11 additions & 0 deletions specification/examples/requests/PATCH_Consent/replace_policy_rule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
ReplacePolicyRuleRequest:
summary: Replace policy rule
description: payload used to add a new policy rule to the consent provision
value:
- op: add
path: /policyRule
value:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: parental-responsibility
display: Parental responsibility
13 changes: 0 additions & 13 deletions specification/examples/requests/PATCH_Consent/replace_regulatory_basis.yaml
View file
Open in desktop

This file was deleted.

11 changes: 5 additions & 6 deletions specification/examples/requests/POST_Consent/adult_to_adult_proxy_creation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ ConsentAdultToAdultGuardianRequest:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000012"
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "court-appointed-personal-welfare-deputy"
display: "Court Appointed Personal Welfare Deputy"
dateTime: "2025-02-11T14:30:00Z"
provision:
type: permit
Expand All @@ -36,12 +41,6 @@ ConsentAdultToAdultGuardianRequest:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created from scratch by GP
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "court-appointed-personal-welfare-deputy"
display: "Court Appointed Personal Welfare Deputy"
- url: http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down
11 changes: 5 additions & 6 deletions specification/examples/requests/POST_Consent/parent_child_proxy_creation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ ConsentParentChildProxyCreationRequest:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000012"
dateTime: "2025-02-11T14:30:00Z"
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: parental-responsibility
display: Parental responsibility
provision:
type: permit
period:
Expand All @@ -43,12 +48,6 @@ ConsentParentChildProxyCreationRequest:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000009'
display: Role created
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "parental-responsibility"
display: "Parental responsibility"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantor
valueReference:
identifier:
Expand Down
22 changes: 10 additions & 12 deletions .../examples/responses/GET_Consent/filtered-relationships-status-active-include-details.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
policy:
- authority: "https://www.england.nhs.uk"
uri: "https://digital.nhs.uk/data-and-information/information-standards/governance/latest-activity/standards-and-collections/dapb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services"
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: parental-responsibility
display: Parental responsibility
provision:
type: permit
actor:
Expand All @@ -137,12 +142,6 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "parental-responsibility"
display: "Parental responsibility"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down Expand Up @@ -225,6 +224,11 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
policy:
- authority: "https://www.england.nhs.uk"
uri: "https://digital.nhs.uk/data-and-information/information-standards/governance/latest-activity/standards-and-collections/dapb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services"
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: parental-responsibility
display: Parental responsibility
provision:
type: permit
actor:
Expand All @@ -249,12 +253,6 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "parental-responsibility"
display: "Parental responsibility"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down
22 changes: 10 additions & 12 deletions specification/examples/responses/GET_Consent/filtered-relationships-status-inactive.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ ConsentMultipleRelationshipsStatusInactiveBundle:
policy:
- authority: 'https://www.england.nhs.uk'
uri: 'https://digital.nhs.uk/data-and-information/information-standards/governance/latest-activity/standards-and-collections/dapb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services'
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: parental-responsibility
display: Parental responsibility
provision:
type: permit
actor:
Expand All @@ -52,12 +57,6 @@ ConsentMultipleRelationshipsStatusInactiveBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_DEACTIVATED_END_DATE_REACHED
display: End date reached
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "parental-responsibility"
display: "Parental responsibility"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down Expand Up @@ -93,6 +92,11 @@ ConsentMultipleRelationshipsStatusInactiveBundle:
policy:
- authority: 'https://www.england.nhs.uk'
uri: 'https://digital.nhs.uk/data-and-information/information-standards/governance/latest-activity/standards-and-collections/dapb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services'
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: parental-responsibility
display: Parental responsibility
provision:
type: permit
actor:
Expand All @@ -113,12 +117,6 @@ ConsentMultipleRelationshipsStatusInactiveBundle:
code: OTHER
display: Other reason
text: Patient would not respond to phone calls
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "parental-responsibility"
display: "Parental responsibility"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down
44 changes: 20 additions & 24 deletions ...ication/examples/responses/GET_Consent/filtered-relationships-status-proposed-active.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
policy:
- authority: 'https://www.england.nhs.uk'
uri: 'https://digital.nhs.uk/data-and-information/information-standards/governance/latest-activity/standards-and-collections/dapb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services'
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: parental-responsibility
display: Parental responsibility
provision:
type: permit
actor:
Expand All @@ -52,12 +57,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "parental-responsibility"
display: "Parental responsibility"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down Expand Up @@ -94,6 +93,11 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
policy:
- authority: 'https://www.england.nhs.uk'
uri: 'https://digital.nhs.uk/data-and-information/information-standards/governance/latest-activity/standards-and-collections/dapb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services'
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: parental-responsibility
display: Parental responsibility
provision:
type: permit
actor:
Expand All @@ -113,12 +117,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "parental-responsibility"
display: "Parental responsibility"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down Expand Up @@ -155,6 +153,11 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
policy:
- authority: 'https://www.england.nhs.uk'
uri: 'https://digital.nhs.uk/data-and-information/information-standards/governance/latest-activity/standards-and-collections/dapb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services'
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: parental-responsibility
display: Parental responsibility
provision:
type: permit
actor:
Expand All @@ -174,12 +177,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: APPLICATION_SUBMITTED
display: Application submitted online
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "parental-responsibility"
display: "Parental responsibility"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down Expand Up @@ -216,6 +213,11 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
policy:
- authority: 'https://www.england.nhs.uk'
uri: 'https://digital.nhs.uk/data-and-information/information-standards/governance/latest-activity/standards-and-collections/dapb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services'
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: parental-responsibility
display: Parental responsibility
provision:
type: permit
actor:
Expand All @@ -235,12 +237,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: APPLICATION_SUBMITTED
display: Application submitted online
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "parental-responsibility"
display: "Parental responsibility"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down
33 changes: 15 additions & 18 deletions ...cation/examples/responses/GET_Consent/multiple-relationships-include-grantee-patient.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ ConsentMultipleRelationshipsIncludeGranteePatientBundle:
policy:
- authority: "https://www.england.nhs.uk"
uri: "https://digital.nhs.uk/data-and-information/information-standards/governance/latest-activity/standards-and-collections/dapb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services"
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: parental-responsibility
display: Parental responsibility
provision:
type: permit
actor:
Expand All @@ -137,12 +142,6 @@ ConsentMultipleRelationshipsIncludeGranteePatientBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "parental-responsibility"
display: "Parental responsibility"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down Expand Up @@ -226,6 +225,11 @@ ConsentMultipleRelationshipsIncludeGranteePatientBundle:
policy:
- authority: "https://www.england.nhs.uk"
uri: "https://digital.nhs.uk/data-and-information/information-standards/governance/latest-activity/standards-and-collections/dapb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services"
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "best-interest"
display: "Best Interest"
provision:
type: permit
actor:
Expand All @@ -245,12 +249,6 @@ ConsentMultipleRelationshipsIncludeGranteePatientBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "best-interest"
display: "Best Interest"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down Expand Up @@ -334,6 +332,11 @@ ConsentMultipleRelationshipsIncludeGranteePatientBundle:
policy:
- authority: "https://www.england.nhs.uk"
uri: "https://digital.nhs.uk/data-and-information/information-standards/governance/latest-activity/standards-and-collections/dapb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services"
policyRule:
- coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "best-interest"
display: "Best Interest"
provision:
type: permit
actor:
Expand All @@ -353,12 +356,6 @@ ConsentMultipleRelationshipsIncludeGranteePatientBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_DEACTIVATED_END_DATE_REACHED
display: End date reached
- url: "http://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.regulatoryBasis"
valueCodeableConcept:
coding:
- system: "https://fhir.nhs.uk/England/CodeSystem/England-NHSProxyLegalBasis"
code: "best-interest"
display: "Best Interest"
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
Expand Down
Loading
Loading