Skip to content

Task/NPA-6616/replace regulatory basis with policy rule#334

Merged
hatwell merged 13 commits intomasterfrom
task/NPA-6637/replace-regulatory-basis-with-policy-rule
Apr 16, 2026
Merged

Task/NPA-6616/replace regulatory basis with policy rule#334
hatwell merged 13 commits intomasterfrom
task/NPA-6637/replace-regulatory-basis-with-policy-rule

Conversation

@hatwell
Copy link
Copy Markdown
Contributor

@hatwell hatwell commented Apr 14, 2026

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-6616


📄 Description/Summary of Changes

  • Remove references to regulatoryBasis and replace it with policyRule.
  • Updates to examples in OAS for GET Consent and GET Consent/{id} response examples, PATCH Consent and POST Consent request examples.
  • Updates to the int postman collection

🧪 Developer Testing Carried Out


📋 PR Principles

  • Keep PRs Small and Focused: Ensure the PR addresses a single task or feature to make it easier to review.
  • Multiple PRs for one Ticket: When splitting work into multiple PRs, clearly describe what this PR addresses and outline the remaining work to complete the ticket.
  • Ensure Tests Are Included: Add or update unit, integration, or end-to-end tests to cover the changes made.
  • Follow Coding Standards: Ensure the code adheres to the team's coding guidelines and best practices.
  • Resolve Comments Promptly: If you raise a comment, ensure you follow up and resolve it before approving the PR to maintain clarity and ensure comments are addressed.
  • Foster Learning: PR reviews are an opportunity to share knowledge, provide constructive feedback, and encourage a collaborative environment.

🏷️ Naming Conventions Reminder

Please ensure the following naming conventions are followed:

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6637

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6637

@hatwell hatwell changed the title Task/npa 6637/replace regulatory basis with policy rule Task/NPA-6616/replace regulatory basis with policy rule Apr 15, 2026
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6637

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6637

Copy link
Copy Markdown
Contributor

@ehallam ehallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@hatwell hatwell merged commit d8b1f0d into master Apr 16, 2026
17 checks passed
@hatwell hatwell deleted the task/NPA-6637/replace-regulatory-basis-with-policy-rule branch April 16, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants