Skip to content

NPA-6521: Investigate hanging sandbox check #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hatwell merged 3 commits into from
Apr 14, 2026
Merged

NPA-6521: Investigate hanging sandbox check #331

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71d4eca
NPA-6521: refactor function to reduce complexity and also have a chan…
hatwell Apr 13, 2026
e38a29c
NPA-6521: kill flask process fully
hatwell Apr 13, 2026
6adfaf5
NPA-6521: revert dummy change
hatwell Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pr-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
# 1. Run Flask in the background (using 'poetry run python -m flask')
# We use FLASK_DEBUG=1 to see the 500 errors in the console
cp -r $GITHUB_WORKSPACE/specification/examples/responses/. $GITHUB_WORKSPACE/sandbox/api/examples/
set -m
FLASK_DEBUG=1 poetry run python -m flask --app api.app:app run -p 9000 &
FLASK_PID=$!

Expand All @@ -46,4 +47,4 @@ jobs:

# 4. Cleanup: Kill the Flask process using the PID we saved
echo "Shutting down Flask..."
kill $FLASK_PID
kill -TERM -$FLASK_PID
Loading