Skip to content

NPA-6521: Investigate hanging sandbox check#331

Merged
hatwell merged 3 commits intomasterfrom
task/NPA-6521/sandbox-check-hanging
Apr 14, 2026
Merged

NPA-6521: Investigate hanging sandbox check#331
hatwell merged 3 commits intomasterfrom
task/NPA-6521/sandbox-check-hanging

Conversation

@hatwell
Copy link
Copy Markdown
Contributor

@hatwell hatwell commented Apr 13, 2026

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-6521


📄 Description/Summary of Changes

  • The job was not showing as completed because some processes in the Flask group weren't being killed at the end of the test run. This change updates the commands to enable job control (set -m) which places all the Flask processes in a process group. It then gracefully shuts down all the processes in that process group.
Screenshot 2026-04-13 at 15 51 40

🧪 Developer Testing Carried Out


📋 PR Principles

  • Keep PRs Small and Focused: Ensure the PR addresses a single task or feature to make it easier to review.
  • Multiple PRs for one Ticket: When splitting work into multiple PRs, clearly describe what this PR addresses and outline the remaining work to complete the ticket.
  • Ensure Tests Are Included: Add or update unit, integration, or end-to-end tests to cover the changes made.
  • Follow Coding Standards: Ensure the code adheres to the team's coding guidelines and best practices.
  • Resolve Comments Promptly: If you raise a comment, ensure you follow up and resolve it before approving the PR to maintain clarity and ensure comments are addressed.
  • Foster Learning: PR reviews are an opportunity to share knowledge, provide constructive feedback, and encourage a collaborative environment.

🏷️ Naming Conventions Reminder

Please ensure the following naming conventions are followed:

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6521

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6521

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6521

@hatwell hatwell merged commit 5bf7dfd into master Apr 14, 2026
17 checks passed
@hatwell hatwell deleted the task/NPA-6521/sandbox-check-hanging branch April 14, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants