Repository navigation
Show the mcs prerequisites in a joined tree on the Dependency Tree page - #806
Conversation
mds's graph records 40 mcs definitions as prerequisites, but the page's tree shows only mds's own divs. Now that mcs publishes its graph (Morrison-Lab/mcs#166), add a second tree that joins the two graphs with the cross-site widget the lds all-notes tree uses. Closes #805 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9mnLpkrgpT23d9m5ee
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9mnLpkrgpT23d9m5ee
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ction (review of #806) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9mnLpkrgpT23d9m5ee
|
The review's not-clean verdict (and so I'm holding the next push (it also takes the review's suggestion to drop the repeated hover and click instructions) until both URLs return 200. That push will re-run the review and the link check. Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
lychee reads the comma-separated attribute as one URL and reports a 404, though both graph files it names return 200. Exclude only that exact string, so a real broken link to either file still fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9mnLpkrgpT23d9m5ee
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Cross-harness review (agy Flash) on e3d7132: VERDICT: CLEAN The new section links valid mcs anchors, the Posted by Claude Code (AI agent) --- not written by a human. |
|
Claude finished review — View run I fetched PR 806 live just now. It is open, not a draft, and not merged ( The prior clean review of VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "a86d2a4af3c79df1e4d0bd5b6bb41318d6050703",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The dependency-tree.qmd section and the anchored lychee.toml exclude are unchanged; the mcs dependency-graph.json and pages all return HTTP 200 now.",
"holistic_assessment": "The only change since the last clean review is a main merge matching git's automatic result, so scope, link-check and integration concerns are unchanged and resolved."
}Reviewed commit: a86d2a4 |
|
Non-Claude reads of this PR's diff at head a86d2a4 (OpenCode Go endpoint; the paid models are at their weekly limit, so the free ids):
I also merged Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
Built to branch |
|
Annotation dispositions for head a86d2a4: I batch-read the annotations of all 50 passing runs on this head (53 annotations in 4 groups). There are no warning or failure annotations; all 53 are notices:
Nothing here needs a fix. Posted by Claude Code (AI agent) --- not written by a human. |
|
Cross-harness review (agy Flash), carried to a86d2a4: VERDICT: CLEAN The CLEAN verdict on e3d7132 (review) carries to this head: Posted by Claude Code (AI agent) --- not written by a human. |
|
Annotation dispositions for head a86d2a4 All 53 annotations on this head's 50 check runs are notices; none is a warning or failure.
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
Post-merge non-Claude re-read of this PR's diff (the same diff as at head a86d2a4), sent to the OpenCode Go endpoint's free ids at 2026-11-12 22:17 PST:
This PR was merged after Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
Requested by Ezra · project thread
Closes #805.
Why
Ezra asked (2026-11-12) whether mds should show a cross-repo tree of how mds builds on mcs. mds's graph already records 40 mcs definitions as prerequisites (391 edges), but the Dependency Tree page shows only mds's own divs. Morrison-Lab/mcs#166 (merged) made mcs publish a graph of its own, so the two can now be joined.
What changed
dependency-tree.qmdgets a second section with a tree that joins the published mcs and mds graphs. It uses the same#dependency-graph-allwidget as the lds all-notes tree, which mds'sdependency-graph.jsalready supports. No script or builder changes.lychee.tomlgets one exact-match exclusion, for thedata-jsonattribute. lychee reads that comma-separated list as one URL and reports a 404, although both files it names return 200. The exclusion matches only that exact string, so a real broken link to either file still fails the check. It's here because this PR fails the link check without it.Verification
quarto render dependency-tree.qmd --to htmlsucceeds.dependency-graph.json. The joined tree drew 1,552 boxes: 1,389 from mds, 162 from mcs, and 1 sds node that mds links to. Each of the 162 mcs boxes links to its mcs page, for examplehttps://morrison-lab.github.io/mcs/expressions-algorithms.html#def-algorithm. The existing site tree is unchanged at 1,389 boxes.mcs/dependency-tree.html,mcs/dependency-graph.jsonandmds/dependency-graph.jsoneach return 200.Generated by Claude Code