Repository navigation
Make the joined dependency tree use the preview's own graph and say which notes each count covers - #813
Conversation
…812) The joined tree named mds's graph by its published URL, so a PR preview joined mcs with main's mds graph while the site tree above it showed the preview's own graph. On #806's preview the two counts disagreed (886 joined, 1389 mds alone) for that reason, and because #806's branch predates #748, whose umbrella pages no longer repeat each section. Name this site's graph by the relative URL dependency-graph.json, and have a joined tree say how many boxes each site defines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrEdwtedWTvaXyTL63i
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Claude finished review — View run This confirming review finds no new issues. The diff against the base is the same three files as in the prior review of 2026-11-13, commit The head moved to
VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "c26b9ac05581feafd7dc361aea62f5e059232575",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Re-read dependency-graph.js per-site counts, the relative data-json URL in dependency-tree.qmd, and the lychee.toml exclusion regex; all remain consistent and no failure mode was found.",
"holistic_assessment": "The diff is unchanged since the prior clean round, the only new commits are clean merges of main and the base PR, and scope stays narrowly on issue 812 with no regression concern."
}Reviewed commit: c26b9ac |
|
Non-Claude reads of this PR's own diff (against #806) at head c26b9ac, through the OpenCode Go endpoint's free ids (paid models at their weekly limit): Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
Built to branch |
|
Annotation dispositions for head c26b9ac All 51 annotations on this head's 47 check runs are notices; none is a warning or failure.
#806 is merged (merge commit af570c1), and this PR is retargeted to Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
Requested by Ezra · project thread
Important
Stacked on #806 (base
claude/project-thread-j628gi). Merge #806 first, with a merge commit, then retarget this tomain.Closes #812.
Why
Ezra asked why the #806 preview shows 1389 definitions and results for mds alone, then only 886 for the tree that joins mds with mcs. Two causes, both in #812:
data-jsonnames mds's graph by its published URL, so a preview joins mcs with main's mds graph (723 mds + 162 mcs + 1 sds = 886), while the site tree shows the preview's own graph.unless-format="html"block, and the graph builder counts those divs twice (1389 instead of 724). That one goes away when Show the mcs prerequisites in a joined tree on the Dependency Tree page #806 is brought up to date with main; this PR doesn't touch it.What changed
dependency-tree.qmd: the joined tree names this site's graph as the relativedependency-graph.json, so a preview joins its own graph and the published site still gets the published one.dependency-graph.js: a joined tree says how many boxes come from each site, e.g. "887 definitions and results (162 from mcs, 724 from mds, 1 from sds), 1378 dependencies, 12 levels." The site tree's line is unchanged.lychee.toml: Show the mcs prerequisites in a joined tree on the Dependency Tree page #806's exact-match exclusion for thedata-jsonstring, updated to the new string.Verification
Ran this branch's
dependency-graph.json the #806 preview page under jsdom (no browser), with the relative URL resolved against a preview path:mainIn both cases the joined tree's mds count now matches the site tree. The same counts come out of a Python re-implementation of the script's layering over the JSON files.
Not rendered with Quarto: the
.qmdchange is one attribute value.typosflagsthmon line 23 ofdependency-graph.js, which this PR doesn't touch.Generated by Claude Code