refactor(snap-solana-wallet): align Solana AssetsService read API with snap-networks-utils - #120
Open
ulissesferreira wants to merge 4 commits into
Open
Conversation
cursor Bot
pushed a commit
that referenced
this pull request
Aug 5, 2026
Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
This was referenced Aug 5, 2026
ulissesferreira
marked this pull request as ready for review
August 5, 2026 18:06
…ks-utils Add getAccountAssetByID, getAccountAssetsByIDs, getAccountAssetsByScope, and getAccountAssetsForAllActiveScopes. Update Keyring, Send, send render, and refreshSend to use the new API. No behavior change — still reads from Snap-owned assetEntities via AssetsRepository. Migrated from MetaMask/snap-solana-wallet#635. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
Drop unused catch binding and account assignment left after the AssetsService read API migration, and prune the stale suppression. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
cursor
Bot
force-pushed
the
ulissesferreira/wpn-1652-align-assets-service-api-6620
branch
from
August 5, 2026 18:09
f5ec399 to
ed3340c
Compare
Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
ulissesferreira
changed the title
ulissesferreira
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Part of migrating the Solana assets-controller staged migration from snap-solana-wallet#635 into this monorepo (PR 1 of 6, Lane A / feature-flag path only).
AssetsService:getAccountAssetByID,getAccountAssetsByIDs,getAccountAssetsByScope,getAccountAssetsForAllActiveScopesaccountsServiceintoAssetsService(needed for account lookup by ID)refreshSendcron to use the new APIassetEntitiesviaAssetsRepositoryCI babysit fixes
SendServiceand prune the stale suppressionmain(Release/5.0.0); restored Unreleased changelog entry above released5.0.0snap.manifest.jsonshasum with the CI production build after rebaseReferences
#90)WPN-1652-snap-assets-adapter(extractSnapAssetsAdapter)Checklist