feat(WPN-1486): remove Solana Snap assets tracking after flag migration - #125
Draft
Conversation
Remove AssetsRepository, SnapAssetsAdapter, and snapOwnedAssets. AssetsService now reads exclusively from AssetsProvider via mapControllerAsset. Drop assetEntities from snap state and update refreshSend, Keyring/Send tests, and exports accordingly. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
cursor
Bot
changed the base branch from
ulissesferreira/wpn-1476-hardcode-core-assets-adapter-flag-6620
to
main
August 5, 2026 15:03
cursor
Bot
changed the title
cursor
Bot
changed the title
cursor
Bot
changed the base branch from
main
to
ulissesferreira/wpn-1476-hardcode-core-assets-adapter-flag-6620
August 5, 2026 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Part of migrating the Solana assets-controller staged migration from snap-solana-wallet#643 into this monorepo (PR 6 of 6, Lane A / feature-flag path only).
SnapAssetsAdapterandAssetsRepository(including NFT snap-owned balance tracking, matching old PR643)assetEntitiesfrom Snap unencrypted stateAssetsServicereads balances exclusively viaAssetsProvider+mapControllerAssetrefreshSendcallers and tests accordinglyNFT metadata via
NftApiClientremains; NFT balance tracking in Snap state is removed (same as old Solana PR643).References
Checklist