Skip to content

temp: failing edge-case example inside remote-feature-flag controller #8120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Prithpal-Sooriya wants to merge 1 commit into
base: main
Choose a base branch
from
+38 −0
Draft

temp: failing edge-case example inside remote-feature-flag controller #8120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions packages/remote-feature-flag-controller/src/remote-feature-flag-controller.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,44 @@ describe('RemoteFeatureFlagController', () => {
});
});

it('processed test threshold feature flag based on order', async () => {
// Test example has a Threshold = 0.380673
const clientConfigApiService = buildClientConfigApiService({
remoteFeatureFlags: {
...MOCK_FLAGS_WITH_THRESHOLD,
testFlagForThreshold: [
{
name: 'groupC',
scope: { type: 'threshold', value: 1 },
value: 'valueC',
},
{
name: 'groupA',
scope: { type: 'threshold', value: 0.3 },
value: 'valueA',
},
{
name: 'groupB',
scope: { type: 'threshold', value: 0.5 }, // We expected groupB, but always get groupC.
value: 'valueB',
},
],
},
});
const controller = createController({
clientConfigApiService,
getMetaMetricsId: () => MOCK_METRICS_ID,
});
await controller.updateRemoteFeatureFlags();

expect(
controller.state.remoteFeatureFlags.testFlagForThreshold,
).toStrictEqual({
name: 'groupB',
value: 'valueB',
});
});

it('preserves non-threshold feature flags unchanged', async () => {
const clientConfigApiService = buildClientConfigApiService({
remoteFeatureFlags: MOCK_FLAGS_WITH_THRESHOLD,
Expand Down
Loading